Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge PHOENIX-6182: IndexTool to verify and repair every index row #1022

Merged
merged 4 commits into from
Dec 17, 2020

Conversation

tkhurana
Copy link
Contributor

No description provided.

…scan (apache#937)

* PHOENIX-6198 Add option to IndexTool to specify the source table for scan

* Addressed feedback for PHOENIX-6198

Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE.
Added the disclaimer for -vAFTER. Also, using the source table enum from
IndexScrutinyTool.
…d PIT_RESULT table (apache#995)

* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table

* Address feedback
reported as beyond max lookback when max lookback is set to 0
Also add ASF license to one file
@tkhurana tkhurana changed the title Merge PHOENIX-6182 Merge PHOENIX-6182: IndexTool to verify and repair every index row Dec 17, 2020
@stoty
Copy link
Contributor

stoty commented Dec 17, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 23s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ 4.x Compile Tests _
+1 💚 mvninstall 14m 6s 4.x passed
+1 💚 compile 1m 0s 4.x passed
+1 💚 checkstyle 1m 36s 4.x passed
+1 💚 javadoc 0m 46s 4.x passed
+0 🆗 spotbugs 3m 3s phoenix-core in 4.x has 958 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 5m 47s the patch passed
+1 💚 compile 1m 2s the patch passed
+1 💚 javac 1m 2s the patch passed
-1 ❌ checkstyle 1m 34s phoenix-core: The patch generated 212 new + 2750 unchanged - 31 fixed = 2962 total (was 2781)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 47s the patch passed
-1 ❌ spotbugs 3m 15s phoenix-core generated 4 new + 958 unchanged - 0 fixed = 962 total (was 958)
_ Other Tests _
-1 ❌ unit 206m 38s phoenix-core in the patch failed.
+1 💚 asflicense 0m 42s The patch does not generate ASF License warnings.
244m 48s
Reason Tests
FindBugs module:phoenix-core
org.apache.phoenix.mapreduce.index.IndexVerificationResultRepository.AFTER_REPAIR_EXTRA_UNVERIFIED_INDEX_ROW_COUNT_BYTES is a mutable array At IndexVerificationResultRepository.java: At IndexVerificationResultRepository.java:[line 136]
org.apache.phoenix.mapreduce.index.IndexVerificationResultRepository.AFTER_REPAIR_EXTRA_VERIFIED_INDEX_ROW_COUNT_BYTES is a mutable array At IndexVerificationResultRepository.java: At IndexVerificationResultRepository.java:[line 133]
org.apache.phoenix.mapreduce.index.IndexVerificationResultRepository.BEFORE_REPAIR_EXTRA_UNVERIFIED_INDEX_ROW_COUNT_BYTES is a mutable array At IndexVerificationResultRepository.java: At IndexVerificationResultRepository.java:[line 129]
org.apache.phoenix.mapreduce.index.IndexVerificationResultRepository.BEFORE_REPAIR_EXTRA_VERIFIED_INDEX_ROW_COUNT_BYTES is a mutable array At IndexVerificationResultRepository.java: At IndexVerificationResultRepository.java:[line 126]
Failed junit tests phoenix.end2end.PermissionNSDisabledWithCustomAccessControllerIT
phoenix.util.IndexScrutinyIT
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1022/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1022
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux c3c138416e7c 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision 4.x / aa468e3
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1022/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1022/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1022/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1022/1/testReport/
Max. process+thread count 6259 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1022/1/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@swaroopak swaroopak merged commit 3b6ea02 into apache:4.x Dec 17, 2020
tkhurana added a commit to tkhurana/phoenix that referenced this pull request Jan 29, 2021
…pache#1022)

* PHOENIX-6198 Add option to IndexTool to specify the source table for scan (apache#937)

* PHOENIX-6198 Add option to IndexTool to specify the source table for scan

* Addressed feedback for PHOENIX-6198

Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE.
Added the disclaimer for -vAFTER. Also, using the source table enum from
IndexScrutinyTool.

* PHOENIX-6199 Generate different query plan depending upon if the source (apache#958)

is index table or data table

* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (apache#995)

* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table

* Address feedback

* PHOENIX-6200 (addendum) Fix test case because invalid rows now are
reported as beyond max lookback when max lookback is set to 0
Also add ASF license to one file
stoty pushed a commit to stoty/phoenix that referenced this pull request Feb 1, 2021
…pache#1022)

* PHOENIX-6198 Add option to IndexTool to specify the source table for scan (apache#937)

* PHOENIX-6198 Add option to IndexTool to specify the source table for scan

* Addressed feedback for PHOENIX-6198

Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE.
Added the disclaimer for -vAFTER. Also, using the source table enum from
IndexScrutinyTool.

* PHOENIX-6199 Generate different query plan depending upon if the source (apache#958)

is index table or data table

* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (apache#995)

* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table

* Address feedback

* PHOENIX-6200 (addendum) Fix test case because invalid rows now are
reported as beyond max lookback when max lookback is set to 0
Also add ASF license to one file
stoty pushed a commit to stoty/phoenix that referenced this pull request Feb 1, 2021
…pache#1022)

* PHOENIX-6198 Add option to IndexTool to specify the source table for scan (apache#937)

* PHOENIX-6198 Add option to IndexTool to specify the source table for scan

* Addressed feedback for PHOENIX-6198

Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE.
Added the disclaimer for -vAFTER. Also, using the source table enum from
IndexScrutinyTool.

* PHOENIX-6199 Generate different query plan depending upon if the source (apache#958)

is index table or data table

* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (apache#995)

* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table

* Address feedback

* PHOENIX-6200 (addendum) Fix test case because invalid rows now are
reported as beyond max lookback when max lookback is set to 0
Also add ASF license to one file
stoty pushed a commit to stoty/phoenix that referenced this pull request Feb 2, 2021
…pache#1022)

* PHOENIX-6198 Add option to IndexTool to specify the source table for scan (apache#937)

* PHOENIX-6198 Add option to IndexTool to specify the source table for scan

* Addressed feedback for PHOENIX-6198

Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE.
Added the disclaimer for -vAFTER. Also, using the source table enum from
IndexScrutinyTool.

* PHOENIX-6199 Generate different query plan depending upon if the source (apache#958)

is index table or data table

* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (apache#995)

* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table

* Address feedback

* PHOENIX-6200 (addendum) Fix test case because invalid rows now are
reported as beyond max lookback when max lookback is set to 0
Also add ASF license to one file
asfgit pushed a commit that referenced this pull request Feb 2, 2021
…1022)

* PHOENIX-6198 Add option to IndexTool to specify the source table for scan (#937)

* PHOENIX-6198 Add option to IndexTool to specify the source table for scan

* Addressed feedback for PHOENIX-6198

Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE.
Added the disclaimer for -vAFTER. Also, using the source table enum from
IndexScrutinyTool.

* PHOENIX-6199 Generate different query plan depending upon if the source (#958)

is index table or data table

* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (#995)

* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table

* Address feedback

* PHOENIX-6200 (addendum) Fix test case because invalid rows now are
reported as beyond max lookback when max lookback is set to 0
Also add ASF license to one file

This port to the master branch also includes a fix for

* PHOENIX-6356 missing row.clear() for dummy row in GlobalIndexRegionScanner
asfgit pushed a commit that referenced this pull request Feb 2, 2021
…1022)

* PHOENIX-6198 Add option to IndexTool to specify the source table for scan (#937)

* PHOENIX-6198 Add option to IndexTool to specify the source table for scan

* Addressed feedback for PHOENIX-6198

Extended the `-from-index` option to support -vBOTH, -vAFTER and -vNONE.
Added the disclaimer for -vAFTER. Also, using the source table enum from
IndexScrutinyTool.

* PHOENIX-6199 Generate different query plan depending upon if the source (#958)

is index table or data table

* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table (#995)

* PHOENIX-6200 Add counters for extra index rows, log results to PIT and PIT_RESULT table

* Address feedback

* PHOENIX-6200 (addendum) Fix test case because invalid rows now are
reported as beyond max lookback when max lookback is set to 0
Also add ASF license to one file

This port to the master branch also includes a fix for

* PHOENIX-6356 missing row.clear() for dummy row in GlobalIndexRegionScanner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants