PHOENIX-6276: Log when hconnection is getting closed in ConnectionQueryServicesImpl #1057

sandeepvinayak · 2021-01-04T20:07:19Z

No description provided.

gjacoby126

Probably better to wrap the HConnection close operation in a method similar to openConnection so that we don't have to duplicate the logging logic each time (and perhaps miss a case)

gjacoby126

+1 assuming a good test run.

ChinmaySKulkarni

Small change requested, otherwise +1

phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java

ChinmaySKulkarni

+1 if preCommit passes. Thanks @sandeepvinayak

stoty · 2021-01-04T22:40:39Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 19s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	15m 26s	master passed
+1 💚	compile	0m 55s	master passed
+1 💚	checkstyle	1m 14s	master passed
+1 💚	javadoc	0m 46s	master passed
+0 🆗	spotbugs	2m 58s	phoenix-core in master has 973 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	8m 11s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
-1 ❌	checkstyle	1m 13s	phoenix-core: The patch generated 14 new + 2196 unchanged - 11 fixed = 2210 total (was 2207)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 45s	the patch passed
+1 💚	spotbugs	3m 18s	the patch passed
		_ Other Tests _
-1 ❌	unit	109m 31s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 28s	The patch does not generate ASF License warnings.
		152m 51s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1057/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1057
JIRA Issue	PHOENIX-6276
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux 1351c53967ba 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / `4d8fcb7`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1057/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1057/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1057/1/testReport/
Max. process+thread count	6831 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1057/1/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2021-01-05T01:05:34Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	14m 18s	master passed
+1 💚	compile	0m 54s	master passed
+1 💚	checkstyle	1m 21s	master passed
+1 💚	javadoc	0m 46s	master passed
+0 🆗	spotbugs	2m 56s	phoenix-core in master has 973 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	7m 36s	the patch passed
+1 💚	compile	0m 52s	the patch passed
+1 💚	javac	0m 52s	the patch passed
-1 ❌	checkstyle	1m 23s	phoenix-core: The patch generated 2 new + 2206 unchanged - 1 fixed = 2208 total (was 2207)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 42s	the patch passed
+1 💚	spotbugs	3m 0s	the patch passed
		_ Other Tests _
-1 ❌	unit	105m 19s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 28s	The patch does not generate ASF License warnings.
		142m 51s

Reason	Tests
Failed junit tests	phoenix.end2end.index.IndexMetadataIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1057/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1057
JIRA Issue	PHOENIX-6276
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux 150d99f25d38 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / `4d8fcb7`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1057/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1057/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1057/2/testReport/
Max. process+thread count	6700 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1057/2/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2021-01-05T05:11:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	14m 40s	master passed
+1 💚	compile	0m 53s	master passed
+1 💚	checkstyle	1m 22s	master passed
+1 💚	javadoc	0m 46s	master passed
+0 🆗	spotbugs	2m 55s	phoenix-core in master has 973 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	7m 25s	the patch passed
+1 💚	compile	0m 54s	the patch passed
+1 💚	javac	0m 54s	the patch passed
-1 ❌	checkstyle	1m 23s	phoenix-core: The patch generated 14 new + 2196 unchanged - 11 fixed = 2210 total (was 2207)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 46s	the patch passed
+1 💚	spotbugs	3m 6s	the patch passed
		_ Other Tests _
-1 ❌	unit	106m 53s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 30s	The patch does not generate ASF License warnings.
		144m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1057/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1057
JIRA Issue	PHOENIX-6276
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux 79f2d49b64af 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / `4d8fcb7`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1057/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1057/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1057/3/testReport/
Max. process+thread count	6571 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1057/3/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java

…ryServicesImpl

stoty · 2021-01-05T10:24:28Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	14m 26s	master passed
+1 💚	compile	0m 54s	master passed
+1 💚	checkstyle	1m 20s	master passed
+1 💚	javadoc	0m 47s	master passed
+0 🆗	spotbugs	2m 52s	phoenix-core in master has 973 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	7m 40s	the patch passed
+1 💚	compile	0m 54s	the patch passed
+1 💚	javac	0m 54s	the patch passed
-1 ❌	checkstyle	1m 20s	phoenix-core: The patch generated 6 new + 2189 unchanged - 18 fixed = 2195 total (was 2207)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 47s	the patch passed
+1 💚	spotbugs	3m 13s	the patch passed
		_ Other Tests _
-1 ❌	unit	107m 37s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 29s	The patch does not generate ASF License warnings.
		145m 36s

Reason	Tests
Failed junit tests	phoenix.end2end.index.IndexMetadataIT

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1057/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1057
JIRA Issue	PHOENIX-6276
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux ec1b41ad4c10 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / `0bac803`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1057/5/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1057/5/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1057/5/testReport/
Max. process+thread count	6560 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1057/5/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani

+1 (non-binding)

gjacoby126 · 2021-01-05T22:04:49Z

Thanks for the patch, @sandeepvinayak. Committing.

gjacoby126 requested changes Jan 4, 2021

View reviewed changes

sandeepvinayak force-pushed the PHOENIX-6276 branch 2 times, most recently from eadee0c to 62e4dde Compare January 4, 2021 21:12

sandeepvinayak requested a review from gjacoby126 January 4, 2021 21:12

gjacoby126 approved these changes Jan 4, 2021

View reviewed changes

ChinmaySKulkarni requested changes Jan 4, 2021

View reviewed changes

phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java Show resolved Hide resolved

phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java Show resolved Hide resolved

sandeepvinayak force-pushed the PHOENIX-6276 branch from 62e4dde to 870bbf1 Compare January 4, 2021 21:49

sandeepvinayak requested a review from ChinmaySKulkarni January 4, 2021 21:49

ChinmaySKulkarni approved these changes Jan 4, 2021

View reviewed changes

sandeepvinayak force-pushed the PHOENIX-6276 branch from 870bbf1 to 61f9c12 Compare January 5, 2021 02:46

sandeepvinayak force-pushed the PHOENIX-6276 branch from 61f9c12 to b834ca3 Compare January 5, 2021 05:29

virajjasani reviewed Jan 5, 2021

View reviewed changes

phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java Outdated Show resolved Hide resolved

PHOENIX-6276: Log when hconnection is getting closed in ConnectionQue…

d703d50

…ryServicesImpl

sandeepvinayak force-pushed the PHOENIX-6276 branch from b834ca3 to d703d50 Compare January 5, 2021 07:58

virajjasani approved these changes Jan 5, 2021

View reviewed changes

sandeepvinayak mentioned this pull request Jan 5, 2021

PHOENIX-6276: Log when hconnection is getting closed in ConnectionQueryServicesImpl #1062

Merged

gjacoby126 merged commit 0880b35 into apache:master Jan 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PHOENIX-6276: Log when hconnection is getting closed in ConnectionQueryServicesImpl #1057

PHOENIX-6276: Log when hconnection is getting closed in ConnectionQueryServicesImpl #1057

sandeepvinayak commented Jan 4, 2021

gjacoby126 left a comment

gjacoby126 left a comment

ChinmaySKulkarni left a comment

ChinmaySKulkarni left a comment

stoty commented Jan 4, 2021

stoty commented Jan 5, 2021

stoty commented Jan 5, 2021

stoty commented Jan 5, 2021

virajjasani left a comment

gjacoby126 commented Jan 5, 2021

PHOENIX-6276: Log when hconnection is getting closed in ConnectionQueryServicesImpl #1057

PHOENIX-6276: Log when hconnection is getting closed in ConnectionQueryServicesImpl #1057

Conversation

sandeepvinayak commented Jan 4, 2021

gjacoby126 left a comment

Choose a reason for hiding this comment

gjacoby126 left a comment

Choose a reason for hiding this comment

ChinmaySKulkarni left a comment

Choose a reason for hiding this comment

ChinmaySKulkarni left a comment

Choose a reason for hiding this comment

stoty commented Jan 4, 2021

stoty commented Jan 5, 2021

stoty commented Jan 5, 2021

stoty commented Jan 5, 2021

virajjasani left a comment

Choose a reason for hiding this comment

gjacoby126 commented Jan 5, 2021