PHOENIX-6329 Eliminate or serialize minicluster restart operations in Integration tests #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virajjasani
approved these changes
Jan 8, 2021
virajjasani
reviewed
Jan 8, 2021
pom.xml
Outdated
| @@ -343,18 +343,6 @@ | |||
| </goals> | |||
| </execution> | |||
| <execution> | |||
| <id>HBaseManagedTimeTests</id> | |||
There was a problem hiding this comment.
Oh this is not even being used
There was a problem hiding this comment.
Must have been copied from HBase, then lurked here for years...
There was a problem hiding this comment.
Looking at again, this still might have effect on Pherf.
It probably should be purged, but not today.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Last test also had a setup error, but it wasn't the timeout error. |
virajjasani
reviewed
Jan 8, 2021
| @@ -708,7 +705,7 @@ protected static String getOrganizationId() { | |||
|
|
|||
| private static long timestamp; | |||
|
|
|||
| public static long nextTimestamp() { | |||
| public static synchronized long nextTimestamp() { | |||
There was a problem hiding this comment.
Looks like this is recent addition right? We could include deletePriorMetaData() too?
There was a problem hiding this comment.
Or maybe just synchronizing deletePriorMetaData() could be enough as it would cover deletePriorTables(), nextTimestamp() and deletePriorSchemas()?
There was a problem hiding this comment.
Those are only used when running the tests on a real cluster, which feature is broken in many ways.
Almost no-one uses it, and it doesn't affect the maven test suite.
And by the pherf tests, which really should be fixed :)
It doesn't hurt to synchronize it.
|
Set all stateful priected static methods to synchronized as well. |
|
FWIW, synchronizing all these methods could be subtask of PHOENIX-6288 and good to directly check for results in multibranch? In the meanwhile we can keep PHOENIX-6288 opened until we get 2-3 multibranch build results without init errors. WDYT @stoty ? |
|
Although PR build#4 should finish sometime soon hopefully. |
|
💔 -1 overall
This message was automatically generated. |
stoty
force-pushed
the
HTUsync
branch
3 times, most recently
from
bbc7962
to
f8a6deb
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
stoty
force-pushed
the
HTUsync
branch
3 times, most recently
from
408cf22
to
f470256
Compare
|
💔 -1 overall
This message was automatically generated. |
stoty
force-pushed
the
HTUsync
branch
3 times, most recently
from
be59311
to
5ed35eb
Compare
stoty
changed the title
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
stoty
force-pushed
the
HTUsync
branch
2 times, most recently
from
a4f02a6
to
2baf251
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
… Integration tests
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.