Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-6376 Update MetaDataProtocol.java for Phoenix 4.17 #1156

Merged
merged 2 commits into from Mar 1, 2021

Conversation

yanxinyi
Copy link
Contributor

No description provided.

@stoty
Copy link
Contributor

stoty commented Feb 27, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 5m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x Compile Tests _
+1 💚 mvninstall 13m 53s 4.x passed
+1 💚 compile 1m 1s 4.x passed
+1 💚 checkstyle 0m 36s 4.x passed
+1 💚 javadoc 0m 47s 4.x passed
+0 🆗 spotbugs 3m 0s phoenix-core in 4.x has 944 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 5m 42s the patch passed
+1 💚 compile 0m 59s the patch passed
+1 💚 javac 0m 59s the patch passed
-1 ❌ checkstyle 0m 36s phoenix-core: The patch generated 5 new + 341 unchanged - 3 fixed = 346 total (was 344)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 44s the patch passed
+1 💚 spotbugs 3m 8s the patch passed
_ Other Tests _
-1 ❌ unit 194m 41s phoenix-core in the patch failed.
+1 💚 asflicense 0m 51s The patch does not generate ASF License warnings.
234m 12s
Reason Tests
Failed junit tests phoenix.end2end.BackwardCompatibilityForSplittableSyscatIT
phoenix.end2end.BackwardCompatibilityIT
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1156/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1156
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux dc3027a68cc2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision 4.x / 8e44658
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1156/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1156/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1156/1/testReport/
Max. process+thread count 5644 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1156/1/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@virajjasani
Copy link
Contributor

Test failures seem relevant @yanxinyi

@yanxinyi
Copy link
Contributor Author

Ok, the BackwardCompatibilityITrequires extra changes. Let me remove theBackwardCompatibilityIT` changes here and create another jira to handle this.

@stoty
Copy link
Contributor

stoty commented Feb 27, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 38s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ 4.x Compile Tests _
+1 💚 mvninstall 14m 58s 4.x passed
+1 💚 compile 1m 14s 4.x passed
+1 💚 checkstyle 0m 39s 4.x passed
+1 💚 javadoc 0m 52s 4.x passed
+0 🆗 spotbugs 3m 47s phoenix-core in 4.x has 944 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 6m 49s the patch passed
+1 💚 compile 1m 9s the patch passed
+1 💚 javac 1m 9s the patch passed
-1 ❌ checkstyle 0m 35s phoenix-core: The patch generated 5 new + 341 unchanged - 3 fixed = 346 total (was 344)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 50s the patch passed
+1 💚 spotbugs 3m 43s the patch passed
_ Other Tests _
+1 💚 unit 128m 51s phoenix-core in the patch passed.
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
165m 13s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1156/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1156
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux d9d3026e4381 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision 4.x / 8e44658
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1156/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1156/2/testReport/
Max. process+thread count 5701 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1156/2/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@yanxinyi
Copy link
Contributor Author

yanxinyi commented Mar 1, 2021

@virajjasani Please take a look again, thanks

@yanxinyi yanxinyi merged commit 9f2623e into apache:4.x Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants