Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-6427 Create sequence fails in lowercase schema #1182

Closed
wants to merge 2 commits into from

Conversation

stoty
Copy link
Contributor

@stoty stoty commented Mar 24, 2021

No description provided.

@@ -253,7 +253,7 @@ public static ColumnResolver getResolverForSchema(UseSchemaStatement statement,
}

public static ColumnResolver getResolverForSchema(String schema, PhoenixConnection connection) throws SQLException {
return new SchemaResolver(connection, SchemaUtil.normalizeIdentifier(schema), true);
return new SchemaResolver(connection, schema, true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one. Ship it.

@stoty
Copy link
Contributor Author

stoty commented Mar 24, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 5m 10s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 15m 49s master passed
+0 hbaserecompile 23m 9s HBase recompiled.
+1 💚 compile 1m 4s master passed
+1 💚 checkstyle 0m 45s master passed
+1 💚 javadoc 0m 51s master passed
+0 🆗 spotbugs 3m 3s phoenix-core in master has 956 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 8m 2s the patch passed
+0 hbaserecompile 45m 57s HBase recompiled.
+1 💚 compile 1m 3s the patch passed
+1 💚 javac 1m 3s the patch passed
-1 ❌ checkstyle 0m 45s phoenix-core: The patch generated 9 new + 553 unchanged - 10 fixed = 562 total (was 563)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 51s the patch passed
+1 💚 spotbugs 3m 16s the patch passed
_ Other Tests _
+1 💚 unit 112m 17s phoenix-core in the patch passed.
+1 💚 asflicense 0m 17s The patch does not generate ASF License warnings.
196m 44s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1182/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1182
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
uname Linux 4414b6082061 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / 2a2d996
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1182/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1182/2/testReport/
Max. process+thread count 9441 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1182/2/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@stoty stoty closed this Mar 25, 2021
@stoty stoty deleted the PHOENIX-6427 branch July 29, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants