Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-6509 PHOENIX-4424 Allow users to create DEFAULT and HBASE Schema (Uppercase Schema Names) #1263

Merged
merged 1 commit into from Jul 10, 2021

Conversation

shahrs87
Copy link
Contributor

@shahrs87 shahrs87 commented Jul 9, 2021

Almost a clean cherry pick of PHOENIX-4424
c075a17

@shahrs87
Copy link
Contributor Author

shahrs87 commented Jul 9, 2021

Cc @virajjasani

@stoty
Copy link
Contributor

stoty commented Jul 9, 2021

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 4m 50s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 💚 mvninstall 23m 24s master passed
+0 hbaserecompile 30m 3s HBase recompiled.
+1 💚 compile 1m 1s master passed
+1 💚 checkstyle 2m 12s master passed
+1 💚 javadoc 0m 52s master passed
+0 🆗 spotbugs 3m 7s phoenix-core in master has 965 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 13m 41s the patch passed
+0 hbaserecompile 24m 10s HBase recompiled.
+1 💚 compile 1m 0s the patch passed
+1 💚 javac 1m 0s the patch passed
-1 ❌ checkstyle 2m 16s phoenix-core: The patch generated 7 new + 3990 unchanged - 8 fixed = 3997 total (was 3998)
-1 ❌ whitespace 0m 0s The patch 1 line(s) with tabs.
+1 💚 javadoc 0m 49s the patch passed
+1 💚 spotbugs 3m 15s the patch passed
_ Other Tests _
-1 ❌ unit 113m 10s phoenix-core in the patch failed.
+1 💚 asflicense 0m 46s The patch does not generate ASF License warnings.
187m 35s
Reason Tests
Failed junit tests phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1263/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1263
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile
uname Linux 6fd8097a199d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / 62f63c8
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1263/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
whitespace https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1263/1/artifact/yetus-general-check/output/whitespace-tabs.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1263/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1263/1/testReport/
Max. process+thread count 14242 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1263/1/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@virajjasani virajjasani merged commit a1044c9 into apache:master Jul 10, 2021
virajjasani pushed a commit that referenced this pull request Jul 10, 2021
…ema (Uppercase Schema Names) (#1263)

Signed-off-by: Viraj Jasani <vjasani@apache.org>
@shahrs87
Copy link
Contributor Author

Thank you @virajjasani for the review and commit !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants