PHOENIX-6555 Wait for permissions to sync in Permission tests #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are successful, but they couldn't update the PR. |
|
Thanks @stoty, will get to review this soon. |
virajjasani
approved these changes
Oct 21, 2021
Comment on lines
+1093
to
+1097
| //Initialize Phoenix to avoid timeouts later | ||
| try (Connection conn = getConnection(); | ||
| Statement stmt = conn.createStatement();) { | ||
| stmt.execute("select * from system.catalog"); | ||
| } |
|
|
||
| @FixMethodOrder(MethodSorters.NAME_ASCENDING) | ||
| public abstract class BasePermissionsIT extends BaseTest { | ||
|
|
||
| private static final Logger LOGGER = LoggerFactory.getLogger(BasePermissionsIT.class); | ||
|
|
||
| private static final int WAIT_TIME = 10000; | ||
|
|
||
| private static String SUPER_USER = System.getProperty("user.name"); |
There was a problem hiding this comment.
Not related to this change, but can be made final if you would like.
| } | ||
| } | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| void grantPermissions(String groupEntry, Permission.Action... actions) throws IOException, Throwable { |
There was a problem hiding this comment.
Looks like IOException is not required, again not relevant but good to update
| public Void call() throws Exception { | ||
| try { | ||
| for (String table : tablesToGrant) { | ||
| AccessControlClient.revoke(getUtility().getConnection(), TableName.valueOf(table), toUser, null, null, actions); |
There was a problem hiding this comment.
nit: checkstyle line len might complain?
|
Thanks @virajjasani , I've addressed your points before commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This copies and used the permission sync code from the HBase tests.