PHOENIX-6649 TransformTool to support views and tenant views #1397
Conversation
gokceni
force-pushed
the
PHOENIX-6649-4.x
branch
from
2fd8eec
to
ec9d1ce
Compare
| } | ||
| PTable newView = Transform.getTransformedView(decendant, newDataTable, columnMap, true); | ||
| QueryPlan queryPlan = getQueryPlan(newView, decendant, connection); | ||
| inputSplits.addAll(generateSplits(queryPlan, configuration)); |
There was a problem hiding this comment.
Does the use of the setMultiInputMapperSplitSize in the TransformTool mean that multiple splits can be worked by the same mapper? (If so that's very good, because we can have lots of small views.) Either way, there's probably lots of future optimization work based on the view size, but we need better stats to be able to do that sort of thing so we can defer for now.
There was a problem hiding this comment.
Let me add a parameter to transform tool since it is 10 now (default).
| PTable newView = Transform.getTransformedView(decendant, newDataTable, columnMap, true); | ||
| QueryPlan queryPlan = getQueryPlan(newView, decendant, connection); | ||
| inputSplits.addAll(generateSplits(queryPlan, configuration)); | ||
| } |
There was a problem hiding this comment.
What happens if the views are not disjoint? Do we just harmlessly transform the same data multiple times into the same shape? Seems like we should have a test for that if we don't already.
| } | ||
|
|
||
|
|
||
| public static Connection getTenantConnection(String tenant) throws SQLException { |
There was a problem hiding this comment.
Could we please get a test for overlapping but still updatable views? (For example, one view is WHERE Foo = 'a' AND Bar = 'b', and another is just WHERE Foo = 'a'.)
There was a problem hiding this comment.
In TransformMonitorExtendedIT I believe you have an updatable and non-updatable tenant view that overlap, but since we skip transforming read-only views, that's not quite the same thing.
There was a problem hiding this comment.
Sure. Will add one.
gokceni
force-pushed
the
PHOENIX-6649-4.x
branch
from
ec9d1ce
to
e45d386
Compare
| stmt1.executeUpdate(); | ||
|
|
||
| createViewSql = "CREATE VIEW " + view2Name + " ( VIEW_COL1 INTEGER, VIEW_COL2 VARCHAR ) AS SELECT * FROM " | ||
| + dataTableFullName1 + " where DATA='GLOBAL_VIEW' AND ZIP=95053"; |
There was a problem hiding this comment.
@gjacoby126 for overlapping view
gokceni
force-pushed
the
PHOENIX-6649-4.x
branch
from
e45d386
to
f78b910
Compare
|
Merged |
No description provided.