Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHOENIX-6806 - Protobufs don't compile on ARM-based Macs (Apple Silicon) #1515

Merged
merged 1 commit into from Oct 10, 2022
Merged

PHOENIX-6806 - Protobufs don't compile on ARM-based Macs (Apple Silicon) #1515

merged 1 commit into from Oct 10, 2022

Conversation

gjacoby126
Copy link
Contributor

No description provided.

@gjacoby126
Copy link
Contributor Author

FYI --

  1. I did test this on an Apple Silicon-based machine to verify that it would work (esp since the CI pipeline won't exercise this change)
  2. The perf hit to protobuf compilation wasn't noticeable.

stoty
stoty approved these changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

Nit: Can you please remove the whitespaces Yetus complains about before committing ?

@gjacoby126
Copy link
Contributor Author

Removed the trailing whitespace on the two lines that yetus warned about. Thanks for the review @stoty

@gjacoby126 gjacoby126 merged commit 92a4a53 into apache:master Oct 10, 2022
tkhurana pushed a commit that referenced this pull request Nov 9, 2022
@gjacoby126
PHOENIX-6806 - Protobufs don't compile on ARM-based Macs (Apple Silic…
fdc7694 
…on) (#1515)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stoty stoty stoty approved these changes

@virajjasani virajjasani Awaiting requested review from virajjasani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gjacoby126 @stoty