PHOENIX-6881 Implement the applicable Date/Time features from JDBC 4.2 #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoty
force-pushed
the
PHOENIX-6881
branch
4 times, most recently
from
829b56a
to
e2efd2e
Compare
richardantal
approved these changes
Mar 21, 2023
| try { | ||
| rs.getObject(2, Long.class); | ||
| fail("We only implement byte[]"); | ||
| } catch (SQLException e) { |
There was a problem hiding this comment.
We could assert on the errorCode or the error message containing Type mismatch when catching these expected Exceptions.
| if (x != null) { | ||
| if (connection.isApplyTimeZoneDisplacement()) { | ||
| x = DateUtil.applyInputDisplacement(x, cal.getTimeZone()); | ||
| return DateUtil.applyInputDisplacement(x, cal.getTimeZone()); | ||
| } else { | ||
| int nanos = x.getNanos(); | ||
| x = new Timestamp(x.getTime()); | ||
| x.setNanos(nanos); |
There was a problem hiding this comment.
It feels a bit inconsistent to the other process functions, but I see the reason why
There was a problem hiding this comment.
Yes, handling nanos is awkward with java.sql.Timestamp.
| public Object toObject(byte[] bytes, int offset, int length, PDataType actualType, | ||
| SortOrder sortOrder, Integer maxLength, Integer scale, Class jdbcType) | ||
| throws SQLException { | ||
| // FIXME according to the JDBC spec, we should support all these types: |
There was a problem hiding this comment.
Could you please create a follow up ticket for this?
|
Thank you, I have implemented your suggestion in the test before commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.