-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHOENIX-7023 : Deprecate columns PHOENIX_TTL and PHOENIX_TTL_HWM and related code #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpisaac
reviewed
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1, Few nits.
Let's chat offline about the message format change
phoenix-core/src/main/java/org/apache/phoenix/compile/CreateTableCompiler.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
Outdated
Show resolved
Hide resolved
jpisaac
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
jpisaac
pushed a commit
to jpisaac/phoenix
that referenced
this pull request
Jul 10, 2024
…related code (apache#1688) * Deprecate columns PHOENIX_TTL and PHOENIX_TTL_HWM and related code Co-authored-by: Lokesh Khurana <lokesh.khurana@salesforce.com>
jpisaac
pushed a commit
to jpisaac/phoenix
that referenced
this pull request
Jul 10, 2024
…related code (apache#1688) * Deprecate columns PHOENIX_TTL and PHOENIX_TTL_HWM and related code Co-authored-by: Lokesh Khurana <lokesh.khurana@salesforce.com>
virajjasani
pushed a commit
that referenced
this pull request
Jul 16, 2024
* PHOENIX-6979 Use HBase TTL as TTL for Tables only at Phoenix Level when phoenix.table.ttl.enabled is true (#1622) * PHOENIX-6979 (Addendum) Use HBase TTL as TTL for Tables only at Phoenix Level when phoenix.table.ttl.enabled is true (#1670) * PHOENIX-7022 :- Add new columns TTL and ROW_KEY_PREFIX (#1660) * PHOENIX-7022 :- Add TTL and ROWKEY_PREFIX Column and Use TTL instead of PHOENIX_TTL for storing TTL in SYSCAT Co-authored-by: Lokesh Khurana <lokesh.khurana@salesforce.com> * PHOENIX-7023 : Deprecate columns PHOENIX_TTL and PHOENIX_TTL_HWM and related code (#1688) * Deprecate columns PHOENIX_TTL and PHOENIX_TTL_HWM and related code Co-authored-by: Lokesh Khurana <lokesh.khurana@salesforce.com> * PHOENIX-7041 Populate ROW_KEY_PREFIX column when creating views (#1733) PHOENIX-7041 Populate ROW_KEY_PREFIX column when creating views --------- Co-authored-by: Jacob Isaac <jisaac@salesforce.com> * PHOENIX-7040 : Support TTL for views using the new column TTL in SYSTEM.CATALOG (#1710) PHOENIX-7040 Support TTL for views using the new column TTL in SYSTEM.CATALOG --------- Co-authored-by: Lokesh Khurana <lokesh.khurana@salesforce.com> * PHOENIX-7041 (ADDENDUM ): Populate ROW_KEY_PREFIX column when creating views (#1821) * Refactored ROW_KEY_PREFIX column name to ROW_KEY_MATCHER * PHOENIX-7040 (ADDENDUM): Support TTL for views using the new column TTL in SYSTEM.CATALOG (#1782) Co-authored-by: lokesh-khurana <lokesh.khurana@salesforce.com> * PHOENIX-6996 :- Provide an upgrade path for Phoenix tables with HBase TTL to move the… (#1752) * Provide an upgrade path for Phoenix tables with HBase TTL to move their TTL spec to SYSTEM.CATALOG * Adding a config to enable/disable ViewTTL feature * PHOENIX-7041 (ADDENDUM-2): ROW_KEY_MATCHER should support various tenantId data types (#1900) * PHOENIX-7329 Change TTL column type to VARCHAR in syscat (#1905) PHOENIX-7329 Changing syscat column to type VARCHAR Co-authored-by: Tanuj Khurana <tkhurana@apache.org> * PHOENIX-7108 Provide support for pruning expired rows of views using Phoenix level compactions (#1908) --------- Co-authored-by: Lokesh Khurana <khuranalokesh07@gmail.com> Co-authored-by: Lokesh Khurana <lokesh.khurana@salesforce.com> Co-authored-by: Jacob Isaac <jisaac@salesforce.com> Co-authored-by: tkhurana <khurana.tanuj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.