PHOENIX-6053 Split Server Side Code into a Separate Module #1690

Aarchy · 2023-09-25T12:42:47Z

No description provided.

stoty

Thank you.

I've left some general comments.
We can talk them over tomorrow.

stoty · 2023-09-26T07:20:27Z

...ix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserverConstants.java

+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.coprocessor;


Having a .coprocessor. package in phoenix-core is iffy.
I'd prefer if we renamed this package to something else, like org.apache.phoenix.scanattributes or similar.

stoty · 2023-09-26T07:28:15Z

phoenix-core/src/main/java/org/apache/phoenix/execute/AggregatePlan.java

@@ -239,18 +243,50 @@ private ParallelIteratorFactory wrapParallelIteratorFactory () {
        // wrap any existing parallelIteratorFactory
        return new WrappingResultIteratorFactory(innerFactory, parallelIteratorFactory);
    }
-
+
+    // TODO better place?


As it is only called from this class place, having it here is fine.
It doesn't need to be static either.

The same goes for other static helpers that were moved out of the coprocessors.

stoty · 2023-09-26T07:29:26Z

phoenix-core/src/main/java/org/apache/phoenix/execute/ClientAggregatePlan.java

@@ -18,6 +18,7 @@
 package org.apache.phoenix.execute;

 import static org.apache.phoenix.query.QueryConstants.UNGROUPED_AGG_ROW_KEY;
+import static org.apache.phoenix.coprocessor.BaseScannerRegionObserverConstants.AGGREGATORS;


It would be nice to be consistent with static imports, but there is no need to clean that up in this patch.

stoty · 2023-09-26T07:31:41Z

phoenix-core/src/main/java/org/apache/phoenix/execute/ScanPlan.java

@@ -128,6 +131,30 @@ public ScanPlan(StatementContext context, FilterableStatement statement, TableRe
        this.rowOffset = rowOffset;
    }

+    // TODO better place?
+    public static void serializeScanRegionObserverIntoScan(Scan scan, int limit,


Maybe add a comment that it is static because it's called from tests

stoty · 2023-09-26T07:40:36Z

phoenix-core/src/main/java/org/apache/phoenix/hbase/index/builder/BaseIndexCodec.java

@@ -17,7 +17,6 @@
 */
 package org.apache.phoenix.hbase.index.builder;


move to org.apache.phoenix.index ?

stoty · 2023-09-26T07:45:55Z

phoenix-core/src/main/java/org/apache/phoenix/index/PhoenixIndexBuilderStatic.java

+import org.apache.phoenix.schema.PTableImpl;
+import org.apache.phoenix.util.TrustedByteArrayOutputStream;
+
+public final class PhoenixIndexBuilderStatic {


The name is probably from my POC , but it would better to call this something like ...Client or ...Helper, or similary.

Thee same goes for all ...Static classes.

Yes, I used those names.,I'll rename them

stoty · 2023-09-26T08:18:04Z

phoenix-core/src/main/java/org/apache/phoenix/schema/task/Task.java

-                throw new IOException(e);
-            }
+
+//    private static List<Mutation> getMutationsForSystemTaskTable(


In the final version remove code instead of commenting it out.

stoty · 2023-09-26T08:20:30Z

phoenix-core/src/main/java/org/apache/phoenix/schema/transform/TransformMaintainer.java

@@ -21,7 +21,6 @@
 import org.apache.phoenix.thirdparty.com.google.common.collect.Maps;
 import org.apache.phoenix.thirdparty.com.google.common.collect.Sets;

-import org.apache.hadoop.hbase.client.Delete;


I can see a lot of files where you are just randomly removing unused imports.
This change is already huge, leaving these alone for now would make it somewhat more managable.

We can handle unrelated cleanups in separate tickets.

This only applies when you only remove non-server unused imports.
When there are other changes, it's fine to clean up them.

stoty · 2023-09-26T08:27:42Z

phoenix-core/src/main/java/org/apache/phoenix/util/ClientUtil.java

+import org.apache.phoenix.exception.SQLExceptionInfo;
+import org.apache.phoenix.schema.StaleRegionBoundaryCacheException;
+
+public class ClientUtil {


When splitting classes to client and server ones, check where it used more often.
In some cases it may beneficial to keep the old name for the client class, and in some cases it may be better to keep it for the server class, whichever makes more sense, or makes the patch smaller.

Checked these, if I'm correct, there are 3 of these kind of splits:

ClientUtil - ServerUtil: Here the original class was ServerUtil, so using ClientUtil on the client side is ok IMO.

Task - ServerTask and ViewUtil - ServerViewUtil: They are similar, there is inheritance between these classes, Server versions are the more specified classes and the name represents this (also they are less used)

stoty

Left some suggestions about names and packages.
Please do another pass to undo the rest of the changes that only affect import order or unused imports.

stoty · 2023-10-04T05:33:57Z

phoenix-coprocessors/pom.xml

+                <artifactId>maven-dependency-plugin</artifactId>
+                <configuration>
+                    <ignoreNonCompile>true</ignoreNonCompile>
+                    <!--           <ignoredUnusedDeclaredDependencies> -->


You can delete these

stoty · 2023-10-04T05:34:52Z

phoenix-coprocessors/pom.xml

+                </configuration>
+                <executions>
+                    <execution>
+                        <!-- generates the file that will be used by the sandbox script


Please check that the sandbox environment still works.

stoty · 2023-10-04T05:36:12Z

phoenix-core/src/main/java/org/apache/phoenix/util/ClientUtil.java

+import org.apache.phoenix.exception.SQLExceptionInfo;
+import org.apache.phoenix.schema.StaleRegionBoundaryCacheException;
+
+public class ClientUtil {


stoty · 2023-10-04T05:38:43Z

phoenix-coprocessors/src/main/java/org/apache/phoenix/coprocessor/AddColumnMutator.java

@@ -443,16 +435,15 @@ public MetaDataMutationResult validateAndAddMetadata(PTable table, byte[][] rowK
    }

    private MetaDataMutationResult compareWithPkColumns(byte[] colName,
-            PTable table, byte[] familyName) {
+                                                        PTable table, byte[] familyName) {


nit:
This looks worse than before

stoty · 2023-10-04T05:45:01Z

...nix-coprocessors/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java

    public static boolean isMaxLookbackTimeEnabled(Configuration conf){
-        return isMaxLookbackTimeEnabled(conf.getLong(PHOENIX_MAX_LOOKBACK_AGE_CONF_KEY,


This is not a scan attribute.
It may be better to move this to QueryServicesOptions.

I think this class (and also the function) is moved to coprocessors package

stoty · 2023-10-04T07:16:19Z

phoenix-core/src/main/java/org/apache/phoenix/cache/TenantCache.java

 import org.apache.phoenix.hbase.index.util.ImmutableBytesPtr;
 import org.apache.phoenix.memory.MemoryManager;
-
+import org.apache.phoenix.scanattributes.ServerCachingProtocol.ServerCacheFactory;


stoty · 2023-10-04T07:17:37Z

phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java

 import org.apache.phoenix.hbase.index.util.IndexManagementUtil;
 import org.apache.phoenix.jdbc.PhoenixDatabaseMetaData;
 import org.apache.phoenix.query.QueryConstants;
 import org.apache.phoenix.query.QueryServices;
+import org.apache.phoenix.scanattributes.MetaDataProtocol;


change not needed

stoty · 2023-10-04T07:18:21Z

phoenix-core/src/main/java/org/apache/phoenix/execute/PhoenixTxIndexMutationGenerator.java

@@ -64,6 +62,7 @@
 import org.apache.phoenix.jdbc.PhoenixConnection;
 import org.apache.phoenix.query.ConnectionQueryServices;
 import org.apache.phoenix.query.KeyRange;
+import org.apache.phoenix.scanattributes.MetaDataProtocol;


change not needed

stoty · 2023-10-04T07:19:17Z

phoenix-core/src/main/java/org/apache/phoenix/filter/SystemCatalogViewIndexIdFilter.java

 import static org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.VIEW_INDEX_ID_BYTES;
 import static org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.VIEW_INDEX_ID_DATA_TYPE_BYTES;
 import static org.apache.phoenix.query.QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES;
+import static org.apache.phoenix.scanattributes.MetaDataProtocol.MIN_SPLITTABLE_SYSTEM_CATALOG;


change not needed

stoty · 2023-10-04T07:41:57Z

phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexerStatic.java

+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.phoenix.query.QueryConstants;
+
+public class IndexerStatic {


Move to IndexUtil or rename to IndexerUtil ?

stoty · 2023-10-10T06:18:35Z

This looks OK to me.
I will invite the community for review.

stoty · 2023-10-10T06:20:54Z

Can you rebase to the current master (unfortunately a few more rebases will likely be needed while the discussion is ongoing) ?
You may also want to squash the commits.

stoty · 2023-10-10T08:49:53Z

I see you haven't touched phoenix-client.
While the ultimate goal is to have a slimmer client, we plan to make a new artifact for that.
For now, phoenix-client should depend on phoenix-coprocessor, so it is basically unchanged.

stoty · 2023-11-20T07:02:21Z

Unfortunately the Zookeeperless code made another large-ish rebase necessary.

richardantal

This change is huge, I tried to check it reasonably thorough but there might be things that I missed.
The change looks mostly good I only left some minor comments on it.

richardantal · 2023-11-28T11:53:22Z

phoenix-tests/pom.xml

+            </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-jar-plugin</artifactId>


I see that it was moved from the phoenix-core, correctly

phoenix/phoenix-core/pom.xml

Lines 124 to 154 in 5128ad0

<plugin>

<groupId>org.apache.maven.plugins</groupId>

<artifactId>maven-jar-plugin</artifactId>

<executions>

<execution>

<phase>prepare-package

</phase>

<goals>

<goal>test-jar</goal>

</goals>

<configuration>

<archive>

<manifest>

<mainClass>org.apache.phoenix.util.GeneratePerformanceData</mainClass>

</manifest>

</archive>

</configuration>

</execution>

</executions>

<configuration>



<excludes>

<exclude>org/apache/jute/**</exclude>

<exclude>org/apache/zookeeper/**</exclude>

<exclude>**/*.jsp</exclude>

<exclude>log4j.properties</exclude>

</excludes>

</configuration>

</plugin>

But I am not sure if we need this maven-jar-plugin, we could check if it can be removed

I'm not sure either, but I think this should be investigated in a separate issue.

I agree that we should not do it as part of this ticket.

richardantal · 2023-11-28T12:02:09Z

phoenix-coprocessors/pom.xml

+        </dependency>
+        <dependency>
+            <groupId>com.github.stephenc.findbugs</groupId>
+            <artifactId>findbugs-annotations</artifactId>


This dependency is duplicated it is there in line 128 too

richardantal · 2023-11-28T12:07:16Z

phoenix-coprocessors/pom.xml

+        </dependency>
+
+
+        <!-- Other dependencies -->


The order of these dependencies are different than the it was originally in the phoenix-core, making it hard to compare.

richardantal · 2023-11-28T12:44:30Z

...rs/src/main/java/org/apache/hadoop/hbase/regionserver/IndexHalfStoreFileReaderGenerator.java

@@ -210,7 +210,7 @@ public InternalScanner preCompact(ObserverContext<RegionCoprocessorEnvironment>
            InternalScanner s, ScanType scanType, CompactionLifeCycleTracker tracker,
            CompactionRequest request) throws IOException {

-        if (!IndexUtil.isLocalIndexStore(store)) { return s; }


Why can't we keep this function in IndexUtil?

I think Store is defined in hbase-server package, IndexUtil is in phoenix-core. We want to break (phoenix-core -> hbase-server) dependency so this function needs to be moved. As its only used in this file, which is indeed in pheonix-coprocessors (which can use hbase-server), I moved it here.

richardantal · 2023-11-28T13:33:53Z

...x-coprocessors/src/main/java/org/apache/phoenix/coprocessor/UncoveredIndexRegionScanner.java

-                        indexMaintainer.deleteRowIfAgedEnough(indexRowKey, indexRow.get(0).getTimestamp(),
-                                ageThreshold, false, region);
+                        if (indexMaintainer.isAgedEnough(ts, ageThreshold)) {
+                            region.delete(indexMaintainer.createDelete(indexRowKey, ts, false));


What are the differences between region.delete and region.batchMutate(mutations); ?

According to hbase documentation:

batchMutate: Perform a batch of mutations. Note this supports only Put and Delete mutations and will ignore other types passed.

delete: Deletes the specified cells/row.

In this specific case the batch contained only 1 delete, so changing it to a single delete operation should do the same.

yep, that is right, that should do the same.
I was curious if you know if there is some performance difference between the 2.

I suppose that possibly could differ between implementations, but HRegion just calls batchMutate in delete if I'm not mistaken.

richardantal · 2023-11-29T12:28:17Z

phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java

@@ -302,6 +298,37 @@ enum JoinType {INNER, LEFT_OUTER}
    int DIVERGED_VIEW_BASE_COLUMN_COUNT = -100;
    int BASE_TABLE_BASE_COLUMN_COUNT = -1;

+    // String constants for the server side class names, so that we don't need the server jar
+    // on the client side
+    final String METADATASPLITPOLICY_CLASSNAME = "org.apache.phoenix.schema.MetaDataSplitPolicy";


Please use underscore to make these 4 variable more readable

richardantal · 2023-11-29T12:41:19Z

phoenix-core/src/main/java/org/apache/phoenix/schema/task/Task.java

-            } catch (SQLException e) {
-                throw new IOException(e);
-            }
+


I am not happy that the order of these function changed.

richardantal · 2023-11-29T13:05:42Z

phoenix-core/src/main/java/org/apache/phoenix/util/MetaDataUtil.java

-            + PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR + zkClientPort
-            + PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR + zkParentNode;
-    }
+    //TODO


Did it got copied to somewhere or what is pending here?

no idea, we should leave this function alone.

Actually, I think I know what happened here.
This function depends on hbase-server which we don't want in phoenix-core. So it should be moved somewhere else, but this fn is not used anywhere. So probably we could just delete it. What do you think?

Dead functions can be removed.

richardantal · 2023-11-30T15:18:15Z

phoenix-tests/src/it/java/org/apache/phoenix/end2end/ExplainPlanWithStatsEnabledIT.java

@@ -1260,7 +1261,7 @@ private void validatePropertyOnViewIndex(String viewName, String viewIndexName,
        PhoenixConnection phxConn = conn.unwrap(PhoenixConnection.class);
        PTable viewIndex = phxConn.getTable(new PTableKey(phxConn.getTenantId(), viewIndexName));
        assertEquals("USE_STATS_FOR_PARALLELIZATION property set incorrectly", useStats,
-                PhoenixConfigurationUtil
+                ScanUtil


We can write this to one line

richardantal · 2023-12-01T08:51:21Z

phoenix-tests/src/test/java/org/apache/phoenix/util/ServerUtilTest.java

@@ -45,13 +45,13 @@ public class ServerUtilTest {
    @Test
    public void testIsHbaseNamespaceAvailableWithExistingNamespace() throws Exception {
        Admin mockAdmin = getMockedAdmin();
-        assertTrue(ServerUtil.isHBaseNamespaceAvailable(mockAdmin, existingNamespaceOne));
+        assertTrue(ClientUtil.isHBaseNamespaceAvailable(mockAdmin, existingNamespaceOne));


it is bit weird calling ClientUtil in ServerUtilTest

Phoenix server side is a superset of client side.
But this could be split to a separate test class.

Fortunately this test class only contains tests for ClientUtil, so I will just rename it to ClientUtilTest.

Aarchy · 2023-12-01T14:09:31Z

@richardantal updated the PR based on your comments.
Thank you for taking time to review this huge patch, really appreciate the feedback!

richardantal

Thank you for doing this change.
I really appreciate the effort that went into this one.
Keep up the fantastic work.

stoty

Phoenix-server is broken.
You need to add the phoenix-coprocessors dependency (or rather replace the phoenix-core dependency with phoenix-coprocessors which should pull in core transitively)

stoty · 2023-12-04T07:32:50Z

Edit: not needed, do as you prefer:

I suggested moving BaseIndexCodec one package higher, but now I see that it was unneccessary.
Can you move it back ? Sorry for flip-flopping.

stoty · 2023-12-04T07:50:41Z

ServerIndexUtil and ServerViewUtil get added to phoenix-client-embedded.
I'm trying to figure out why.

stoty · 2023-12-04T08:16:04Z

ServerIndexUtil and ServerViewUtil get added to phoenix-client-embedded because we depend on phoenix-coprocessors for compatibility reasons. So that's fine.

stoty · 2023-12-04T08:26:53Z

I have also renamed the ticket, so please update the commit message to the new name as well.

Aarchy · 2023-12-04T09:03:28Z

@stoty Added phoenix-coprocessors dependency to phoenix-server and modified the commit msg.

stoty · 2023-12-04T09:12:15Z

I got this error when running mvn install.

[INFO] --- maven-dependency-plugin:3.1.1:analyze-only (enforce-dependencies) @ phoenix-tests ---
[WARNING] Used undeclared dependencies found:
[WARNING] org.apache.zookeeper:zookeeper-jute:jar:3.5.7:compile
[INFO] ------------------------------------------------------------------------

Test dependencies are not transitive, you need to add everything that phoenix-core depends on.
(Or just add phoenix-core as a non-test dependency)

stoty · 2023-12-04T09:17:20Z

Come to think of it, we should do this properly.
Remove the transitive dependencies from phoenix-tests, and set the phoenix-core dependency to compile.
You may have to add an exclusion for this in the maven-dependency-plugin config

stoty · 2023-12-04T16:46:01Z

Ignore my previous comment, I was wrong.

stoty · 2023-12-04T16:47:16Z

The dependency-plugin will warn about all undefined dependencies, it explicitly doesn't want to see transitive dependencies.

stoty · 2023-12-04T16:50:45Z

We could in fact change the scope to test for most dependencies.

stoty · 2023-12-04T19:26:38Z

You only need to add the zookeeper-jute dependency

Aarchy · 2023-12-05T08:48:06Z

Weird, if I add zookeeper-jute I get the following error:

[INFO] --- dependency:3.1.1:analyze-only (enforce-dependencies) @ phoenix-tests ---
[WARNING] Unused declared dependencies found:
[WARNING] org.apache.zookeeper:zookeeper-jute:jar:3.5.7:test

stoty · 2023-12-05T09:32:53Z

It depends on the java version.
Java 11 fails with "Used undeclared dependencies found:"

But if we add it, then Java 8 fails with "Unused declared dependencies found:"

Please add the exclusion both ways into the maven-dependency-plugin config, with a comment explaining the situation.

Aarchy · 2023-12-05T10:01:31Z

Do we need to add two way exclusion?
I suppose just one of these warnings is right, so wouldn't it be better to just add exclusion for the faulty case? This way, at least the declared dependencies would be correct.

stoty · 2023-12-05T10:15:10Z

That's also fine.

I have disassembled tests, and even though there is no include for zookeeper-jute, it does in fact call a method whoose return value is defined in zk-jute.

Why this is dependent on java version is beyond me.

Aarchy · 2023-12-05T12:29:07Z

@stoty I've added the zk-jute dependency and also the exclusion.

stoty · 2023-12-05T16:20:58Z

Thank you, @Aarchy .

stoty · 2023-12-05T17:25:31Z

As discussed ofline, we have found a more compatible module naming scheme:
phoenix-core -> phoenix-core-client
phoenix-coprocessors -> phoenix-core-server
phoenix-test > phoenix-core (the original module)

phoenix-core depends on phoenix-core-server and phoenix-server-client, and includes all the tests.

This maximizes compatbility with existing maven consumers and downstream projects.

stoty · 2023-12-06T08:56:59Z

We can put phoenix-core-client and phoenix-core-server under the phoenix-core directory, or we can have a flat directory structure, I don't really have a preference.

stoty · 2023-12-06T13:29:07Z

You also need adopt (or rather revert) phoenix-sandbox.py to these changes.

stoty

+1 LGTM

stoty

-1 I looked into the the Apache CI tests,and every single one has timed out.
Need to dig into that before merging.

stoty · 2023-12-07T07:04:31Z

WALRecoveryRegionPostOpenIT is hanging (at least in the latest run)

stoty · 2023-12-07T08:11:11Z

The hang is definielty caused by this patch.
Maybe a bad merge ?

stoty · 2023-12-07T08:29:09Z

So I have confirmed that the hang is caused by this patch. The test ran fine more than five times in a row without the patch, but failed every time I tried with the patch.

It doesn't seem to be a problem with the test code itself, so the patch must have introduced some other error, which causes the hang.

Now we just need to figure out which one of the 1300 changed files went wrong.

Aarchy · 2023-12-11T14:10:22Z

@stoty Thanks for pointing this out and the offline help as well.
There were two enableIndexing functions (one in Indexer.java and another one in IndexRegionObserver.java) but they set different coprocessors. I missed it, and just kept the IndexRegionObserver version in IndexerUtil. Changing it to use the correct coprocessors fixed the issue.

stoty requested changes Sep 26, 2023

View reviewed changes

Aarchy force-pushed the client branch 4 times, most recently from 5d6a009 to f3af6de Compare October 3, 2023 08:46

stoty requested changes Oct 4, 2023

View reviewed changes

Aarchy force-pushed the client branch 2 times, most recently from c4d3811 to a9c41e1 Compare October 9, 2023 10:06

Aarchy requested a review from stoty October 9, 2023 11:10

Aarchy force-pushed the client branch from 0eb51dc to 1e33760 Compare October 10, 2023 06:46

Aarchy force-pushed the client branch from 1e33760 to f5e8652 Compare October 10, 2023 12:24

Aarchy marked this pull request as ready for review October 18, 2023 09:01

Aarchy force-pushed the client branch 2 times, most recently from 7f95ac4 to 40c2c20 Compare November 20, 2023 15:14

richardantal reviewed Dec 1, 2023

View reviewed changes

Aarchy force-pushed the client branch 2 times, most recently from 79c6f0e to 00ff1da Compare December 1, 2023 14:05

Aarchy requested a review from richardantal December 1, 2023 14:09

richardantal approved these changes Dec 1, 2023

View reviewed changes

stoty requested changes Dec 4, 2023

View reviewed changes

Aarchy force-pushed the client branch from 00ff1da to e89f8b2 Compare December 4, 2023 09:02

Aarchy changed the title ~~PHOENIX-6053 Use shaded hadoop-client and hbase-shaded-client in phoenix-client~~ PHOENIX-6053 Split Server Side Code into a Separate Module Dec 4, 2023

Aarchy force-pushed the client branch from e89f8b2 to 517543d Compare December 5, 2023 10:33

Aarchy force-pushed the client branch from 517543d to d84a381 Compare December 6, 2023 12:07

Aarchy force-pushed the client branch from d84a381 to e5b8477 Compare December 6, 2023 13:46

stoty approved these changes Dec 6, 2023

View reviewed changes

stoty reviewed Dec 7, 2023

View reviewed changes

PHOENIX-6053 Split Server Side Code into a Separate Module

3267353

Aarchy force-pushed the client branch from e5b8477 to 3267353 Compare December 11, 2023 14:02

stoty closed this Dec 12, 2023

		@@ -17,7 +17,6 @@
		*/
		package org.apache.phoenix.hbase.index.builder;

		public static boolean isMaxLookbackTimeEnabled(Configuration conf){
		return isMaxLookbackTimeEnabled(conf.getLong(PHOENIX_MAX_LOOKBACK_AGE_CONF_KEY,

	<plugin>
	<groupId>org.apache.maven.plugins</groupId>
	<artifactId>maven-jar-plugin</artifactId>
	<executions>
	<execution>
	<phase>prepare-package
	</phase>
	<goals>
	<goal>test-jar</goal>
	</goals>
	<configuration>
	<archive>
	<manifest>
	<mainClass>org.apache.phoenix.util.GeneratePerformanceData</mainClass>
	</manifest>
	</archive>
	</configuration>
	</execution>
	</executions>
	<configuration>
	<!-- Exclude these 2 packages, because their dependency _binary_ files
	include the sources, and Maven 2.2 appears to add them to the sources to compile,
	weird -->
	<excludes>
	<exclude>org/apache/jute/**</exclude>
	<exclude>org/apache/zookeeper/**</exclude>
	<exclude>*/.jsp</exclude>
	<exclude>log4j.properties</exclude>
	</excludes>
	</configuration>
	</plugin>

PHOENIX-6053 Split Server Side Code into a Separate Module #1690

PHOENIX-6053 Split Server Side Code into a Separate Module #1690

Conversation

Aarchy commented Sep 25, 2023

stoty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stoty left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stoty commented Oct 10, 2023

stoty commented Oct 10, 2023

stoty commented Oct 10, 2023

stoty commented Nov 20, 2023

richardantal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Aarchy commented Dec 1, 2023

richardantal left a comment

Choose a reason for hiding this comment

stoty left a comment • edited

Choose a reason for hiding this comment

stoty commented Dec 4, 2023 • edited

stoty commented Dec 4, 2023

stoty commented Dec 4, 2023

stoty commented Dec 4, 2023

Aarchy commented Dec 4, 2023

stoty commented Dec 4, 2023

stoty commented Dec 4, 2023

stoty commented Dec 4, 2023

stoty commented Dec 4, 2023

stoty commented Dec 4, 2023

stoty commented Dec 4, 2023

Aarchy commented Dec 5, 2023

stoty commented Dec 5, 2023

Aarchy commented Dec 5, 2023

stoty commented Dec 5, 2023

Aarchy commented Dec 5, 2023

stoty left a comment •

edited

stoty commented Dec 4, 2023 •

edited

stoty commented Dec 5, 2023 •

edited