PHOENIX-7074 DROP CDC Implementation #1713
Conversation
|
|
||
| String indexName = CDCUtil.getCDCIndexName(statement.getCdcObjName().getName()); | ||
| // Dropping the uncovered index associated with the CDC Table | ||
| return dropTable(schemaName, indexName, parentTableName, PTableType.INDEX, statement.ifExists(), false, false); |
There was a problem hiding this comment.
In create, we are catching SQLExceptions on index creation and translating them on to CDC so that user wouldn't be exposed to the index name that is internal to the CDC implementation. We should probably do something similar here.
There was a problem hiding this comment.
Updated: Handled the SQLExceptions from dropping the Index and created a CDC Wrapper Exception on it.
I think we need not worry about dropping the CDC index directly as we are creating the index with the 2 underscores in the beginning which is preventing the index to be dropped directly.
I tried doing the same but was getting parser exceptions -
0: jdbc:phoenix:localhost> DROP INDEX __CDC__CDCTABLE ON DATATABLE; Error: ERROR 601 (42P00): Syntax error. Unexpected char: '_' (state=42P00,code=601) org.apache.phoenix.exception.PhoenixParserException: ERROR 601 (42P00): Syntax error. Unexpected char: '_' at org.apache.phoenix.exception.PhoenixParserException.newException(PhoenixParserException.java:33)
There was a problem hiding this comment.
underscores in the beginning which is preventing the index to be dropped directly.
You can still drop it by putting double quotes around the index name.
virajjasani
changed the title
| return dropTable(schemaName, indexName, parentTableName, PTableType.INDEX, statement.ifExists(), false, false); | ||
| } catch (SQLException e) { | ||
| throw new SQLExceptionInfo.Builder(SQLExceptionCode.fromErrorCode(e.getErrorCode())) | ||
| .setTableName(statement.getCdcObjName().getName()).build().buildException(); |
There was a problem hiding this comment.
Missing setRootCause(). The same applies to create CDC as well, which I will fix in the next PR.
| if (CDCUtil.isACDCIndex( | ||
| ExecutableDropIndexStatement.this.getIndexName().getName())) { | ||
| throw new SQLExceptionInfo.Builder(CANNOT_DROP_CDC_INDEX).setTableName( | ||
| ExecutableDropIndexStatement.this.getIndexName().getName()) |
There was a problem hiding this comment.
Nit: ExecutableDropIndexStatement.this.getIndexName().getName() could be assigned to a local variable to avoid repetition.
TheNamesRai
force-pushed
the
DropCDCImpl
branch
from
406493a
to
1b01ebb
Compare
This commit includes a squash of all the below changes from the PRs apache#1662, apache#1694, down by removing non-functional changes for the ease of review. On top of it, the changes have been reworked for the changed state of master, especially the new submodules. * 4c9827a Hari.. PHOENIX-7008 Shallow grammar support for CREATE CDC (apache#1662) * e5220e0 TheN.. PHOENIX-7054 Shallow grammar support for DROP CDC and ALTER CDC (apache#1694) * 581e613 Hari.. PHOENIX-7008 Implementation for CREATE CDC (apache#1681) * e2ef886 Hari.. PHOENIX-7008 Tweaks, fixes and additional test coverage for CREATE CDC (apache#1703) * 5d3fd40 TheN.. PHOENIX-7074 DROP CDC Implementation (apache#1713) * 7420443 Hari.. PHOENIX-7014: Query compiler/optimizer changes along with some PHOENIX-7015 changes (apache#1766) * da6ddad Kadi.. Add an extra delete mutation for CDC * 93d586e Kadi.. Add an extra delete mutation during rebuild for CDC index * f07898f Hari.. PHOENIX-7008: Addressing Jira spec and review feedback changes (apache#1802) * 87a2ea1 Hari.. PHOENIX-7008: Fix for parser gap and fix for failing test (apache#1812) * e395780 TheN.. PHOENIX-7015 Implementing CDCGlobalIndexRegionScanner (apache#1813) Co-authored-by: Saurabh Rai <saurabh.rai@salesforce.com>
…ture This commit includes a squash of all the below changes from the PRs apache#1662, apache#1694, down by removing non-functional changes for the ease of review. On top of it, the changes have been reworked for the changed state of master, especially the new submodules. * 4c9827a Hari.. PHOENIX-7008 Shallow grammar support for CREATE CDC (apache#1662) * e5220e0 TheN.. PHOENIX-7054 Shallow grammar support for DROP CDC and ALTER CDC (apache#1694) * 581e613 Hari.. PHOENIX-7008 Implementation for CREATE CDC (apache#1681) * e2ef886 Hari.. PHOENIX-7008 Tweaks, fixes and additional test coverage for CREATE CDC (apache#1703) * 5d3fd40 TheN.. PHOENIX-7074 DROP CDC Implementation (apache#1713) * 7420443 Hari.. PHOENIX-7014: Query compiler/optimizer changes along with some PHOENIX-7015 changes (apache#1766) * da6ddad Kadi.. Add an extra delete mutation for CDC * 93d586e Kadi.. Add an extra delete mutation during rebuild for CDC index * f07898f Hari.. PHOENIX-7008: Addressing Jira spec and review feedback changes (apache#1802) * 87a2ea1 Hari.. PHOENIX-7008: Fix for parser gap and fix for failing test (apache#1812) * e395780 TheN.. PHOENIX-7015 Implementing CDCGlobalIndexRegionScanner (apache#1813) Co-authored-by: Saurabh Rai <saurabh.rai@salesforce.com>
This PR builds on top of the shallow grammar support added for DROP CDC grammar as part of #1694. This change makes the required changes to DROP CDC object and the Uncovered Index associated with it.
Jira: PHOENIX-7074