PHOENIX-7076 : MetaDataRegionObserver#postOpen hook improvements #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virajjasani
reviewed
Nov 9, 2023
| @@ -109,13 +112,16 @@ public class MetaDataRegionObserver implements RegionObserver,RegionCoprocessor | |||
| QueryConstants.SYSTEM_SCHEMA_NAME_BYTES, | |||
| PhoenixDatabaseMetaData.SYSTEM_CATALOG_TABLE_BYTES); | |||
| protected ScheduledThreadPoolExecutor executor = new ScheduledThreadPoolExecutor(1); | |||
| private ScheduledThreadPoolExecutor truncateTaskExectuor = new ScheduledThreadPoolExecutor(1, | |||
| new ThreadFactoryBuilder().setDaemon(true).setNameFormat("task-truncated%s").build()); | |||
| @@ -158,6 +158,7 @@ public interface QueryServices extends SQLCloseable { | |||
| public static final String INDEX_FAILURE_HANDLING_REBUILD_INTERVAL_ATTRIB = | |||
| "phoenix.index.failure.handling.rebuild.interval"; | |||
| public static final String INDEX_REBUILD_TASK_INITIAL_DELAY = "phoenix.index.rebuild.task.initial.delay"; | |||
| public static final String INDEX_START_TRUNCATE_TASK_DELAY = "phoenix.index.start.truncate.task.delay"; | |||
There was a problem hiding this comment.
stats truncate is not related to index, so let's remove "index" from configs everywhere
| @@ -216,6 +216,7 @@ public class QueryServicesOptions { | |||
| public static final boolean DEFAULT_INDEX_FAILURE_THROW_EXCEPTION = true; | |||
| public static final long DEFAULT_INDEX_FAILURE_HANDLING_REBUILD_INTERVAL = 60000; // 60 secs | |||
| public static final long DEFAULT_INDEX_REBUILD_TASK_INITIAL_DELAY = 10000; // 10 secs | |||
| public static final long DEFAULT_INDEX_START_TRUNCATE_TASK_DELAY = 20000; // 20 secs | |||
tkhurana
reviewed
Nov 10, 2023
| @@ -156,6 +162,10 @@ public void start(CoprocessorEnvironment env) throws IOException { | |||
| config.getLong( | |||
| QueryServices.INDEX_REBUILD_TASK_INITIAL_DELAY, | |||
| QueryServicesOptions.DEFAULT_INDEX_REBUILD_TASK_INITIAL_DELAY); | |||
| startTruncateTaskDelay = | |||
| config.getLong( | |||
| QueryServices.INDEX_START_TRUNCATE_TASK_DELAY, | |||
There was a problem hiding this comment.
what has this config got to do with index ?
tkhurana
reviewed
Nov 10, 2023
| private boolean enableRebuildIndex = QueryServicesOptions.DEFAULT_INDEX_FAILURE_HANDLING_REBUILD; | ||
| private long rebuildIndexTimeInterval = QueryServicesOptions.DEFAULT_INDEX_FAILURE_HANDLING_REBUILD_INTERVAL; | ||
| private static Map<PName, Long> batchExecutedPerTableMap = new HashMap<PName, Long>(); | ||
| @GuardedBy("MetaDataRegionObserver.class") | ||
| private static Properties rebuildIndexConnectionProps; | ||
| // Added for test purposes | ||
| private long initialRebuildTaskDelay; | ||
| private long startTruncateTaskDelay; |
There was a problem hiding this comment.
rename this to statsTruncateTaskDelay
tkhurana
reviewed
Nov 16, 2023
| if (env.getConfiguration() | ||
| .getBoolean(STATS_COLLECTION_ENABLED, DEFAULT_STATS_COLLECTION_ENABLED)) { | ||
| truncateTaskExectuor.schedule(r, statsTruncateTaskDelay, TimeUnit.MILLISECONDS); | ||
| } |
There was a problem hiding this comment.
Add an else clause and then you can add a log there "Stats collection is disabled"
tkhurana
approved these changes
Nov 20, 2023
Divneet18
added a commit
to Divneet18/phoenix
that referenced
this pull request
Dec 12, 2023
…che#1735) * PHOENIX-7076 : MetaDataRegionObserver#postOpen hook improvements * updated import and fixed checkstyle * fixed checkstyle * changed varialbe names and few other nits * Added logger info --------- Co-authored-by: divneet-kaur <divneet.kaur@salesforce.com>
virajjasani
pushed a commit
that referenced
this pull request
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.