-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHOENIX-7140 Update Apache Parent and Maven Plugin Versions in Core #1760
Conversation
NihalJain
commented
Dec 13, 2023
- Apache Parent pom updated to v30
- Versions for the following plugins removed as they are derived from parent pom:
- maven-enforcer-plugin
- maven-shade-plugin
- maven-project-info-reports-plugin
- Unused property surefire.version has been removed
- Properties findbugs-annotations.version, maven-owasp-plugin.version, and os.maven.version have been relocated
- Versions for these plugins are now managed via properties:
- jasmine-maven-plugin
- lifecycle-mapping
- maven-bundle-plugin
- exec-maven-plugin
- maven-checkstyle-plugin
- Upgraded versions for these plugins:
- maven-eclipse-plugin to 2.10
- maven-build-helper-plugin to 3.5.0
- restrict-imports.enforcer to 2.4.0
- spotbugs-maven-plugin to 4.8.1.0
- spotbugs to 4.8.1
- jacoco-maven-plugin to 0.8.11
- sonar-maven-plugin to 3.10.0.2594
- maven-owasp-plugin to 8.4.0
- os.maven to 1.7.1
- maven-bundle-plugin to 5.1.9
- exec-maven-plugin to 3.1.1
- maven-checkstyle-plugin to 3.3.0
- Updated checker.xml based on updated checkstyle, refer Change LineLength Check parent from TreeWalker to Checker checkstyle/checkstyle#2116
- Switched to as the old declaration variant no longer supported, refer https://github.com/skuzzle/restrict-imports-enforcer-rule/releases/tag/v2.0.0
- Temporarily retained old version of apache parent for maven-dependency-plugin as upgrading is causing build to fail
Ran following locally and verified build is SUCCESS:
Also could not figure out how to pretty format the message in patch mode. Tried to commit with a message stored in a file having \n at end: CC: @stoty |
You can just use git commit --amend, and edit the patch in your favourite unix-ish command line editor. |
Sorry, misclicked. |
fb07e9e
to
8df68fa
Compare
- Apache Parent pom updated to v30 - Versions for the following plugins removed as they are derived from parent pom: - maven-enforcer-plugin - maven-shade-plugin - maven-project-info-reports-plugin - Unused property surefire.version has been removed - Properties findbugs-annotations.version, maven-owasp-plugin.version, and os.maven.version have been relocated - Versions for these plugins are now managed via properties: - jasmine-maven-plugin - lifecycle-mapping - maven-bundle-plugin - exec-maven-plugin - maven-checkstyle-plugin - Upgraded versions for these plugins: - maven-eclipse-plugin to 2.10 - maven-build-helper-plugin to 3.5.0 - restrict-imports.enforcer to 2.4.0 - spotbugs-maven-plugin to 4.8.1.0 - spotbugs to 4.8.1 - jacoco-maven-plugin to 0.8.11 - sonar-maven-plugin to 3.10.0.2594 - maven-owasp-plugin to 8.4.0 - os.maven to 1.7.1 - maven-bundle-plugin to 5.1.9 - exec-maven-plugin to 3.1.1 - maven-checkstyle-plugin to 3.3.0 - Updated checker.xml based on updated checkstyle, refer checkstyle/checkstyle#2116 - Updated DTD version to be inline with phoenix-omid - Switched to <RestrictImports> as the old declaration variant no longer supported, refer https://github.com/skuzzle/restrict-imports-enforcer-rule/releases/tag/v2.0.0 - Temporarily retained old version of apache parent for maven-dependency-plugin as upgrading is causing build to fail
8df68fa
to
47bf137
Compare
Phew! Fixed the message: Force pushed: updated DTD version to be same as omid, not sure how to validate as |