PHOENIX-6721 CSV bulkload tool fails with FileNotFoundException if --… #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…output points to the S3 location Co-authored-by: Istvan Toth <stoty@apache.org>
|
FYI @steveloughran Is this version correct ? I have tested this with both HDFS and S3 outputdir. |
|
It looks good to me. I don't quite remember why I didn't use getWorkPath in the first place, but if it works as expected, then I have no objections. Thank you so much, Istvan! |
ss77892
approved these changes
Dec 14, 2023
chrajeshbabu
approved these changes
Dec 15, 2023
|
Merged manually. |
@ss77892 we only pulled it up from a FileOutputFormat into an interface with the s3a committer work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…output points to the S3 location
This is @ss77892 's patch, rebased, and using getWorkPath() instead of getOutputPath()