PHOENIX-7155 Validate Partial Index support with JSON #1767
Conversation
ranganathg
force-pushed
the
partialIndexTest
branch
from
64b40e1
to
a9ef832
Compare
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/PartialIndexIT.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/PartialIndexIT.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/PartialIndexIT.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/main/java/org/apache/phoenix/compile/CreateIndexCompiler.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/PartialIndexIT.java
Outdated
Show resolved
Hide resolved
Minor changes in JSON Functions
Thanks @gjacoby126 . As per my understanding - The JSON specification does not include comments, and they cannot be used in JSON files. |
We can eliminate the json file and use a static map (see BaseTest) or an array instead. |
I would prefer to have json data in separate json files itself. If it's within a Java file, its not readable and IDE support to modify JSON with java static map wouldn't be clean. |
Pushed new changes for this. |
| // Add rows to the data table before creating a partial index to test that the index | ||
| // will be built correctly by IndexTool | ||
| conn.createStatement().execute( | ||
| "upsert into " + dataTableName + " values ('id1', 70, 2, 3.14, 'a','" + getJsonString( |
There was a problem hiding this comment.
To improve the readability of the tests, we should include the json doc payload directly in the string for the upsert statement instead of retrieving from a file. The json doc should include only the content necessary for this test. For example, for this test the string for the doc could be ‘{"info": {"address ": {"exits" : true}}}’. If the same json string is used multiple times then we can define a string constant.
There was a problem hiding this comment.
Sure makes sense. Will make these changes
It is not easy to read the test when the input is in a non-java file that cannot be accessed with a shortcut or link. If the input is large then this is acceptable but for a tiny input, it is inconvenient. |
|
@ranganathg - If you keep the JSON, exceptions to the license check can be added here: https://github.com/apache/phoenix/blob/master/pom.xml#L636 |
This is nice. Thank you @gjacoby126 |
Took your comment and this made the code much simpler and easy to read. Thank you :) |
ranganathg
force-pushed
the
partialIndexTest
branch
from
ce5045d
to
adf668d
Compare
* PHOENIX-628 - Support native JSON data type (apache#1667) 1. Update the SQL Exception code to reflect ComparisonNotSupportedException 2. Changed function name from Equality to Comparison. * PHOENIX-7058 : Implement json_query function on the json object (apache#1696) * PHOENIX-7044 : Support Index on a generated column that extracts a scalar value from JSON column (apache#1708) * PHOENIX-7099 : Implement JSON_EXISTS function on json object (apache#1732) * PHOENIX-7099 : Implement JSON_EXISTS function on json object * PHOENIX-7073 : Parse JSON columns on the server side (apache#1712) * PHOENIX-7073 : Parse JSON columns on the server side * PHOENIX-7155 Validate Partial Index support with JSON (apache#1767)
PHOENIX-7155