PHOENIX-7316 Need close more Statements #1894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaijunjie0101
force-pushed
the
PHOENIX-7316
branch
2 times, most recently
from
1c258d1
to
0f207c8
Compare
stoty
reviewed
Jun 19, 2024
| PreparedStatement delegateStmt = QueryUtil.getTablesStmt(stmt.getConnection(), null, | ||
| getTargetSchema(), getDbPattern(), null); | ||
| return ((PhoenixPreparedStatement) delegateStmt).compileQuery(); | ||
| try (PreparedStatement delegateStmt = |
There was a problem hiding this comment.
This is suspicious.
We keep using the query plan returned from the closed statement.
There was a problem hiding this comment.
This is suspicious. We keep using the query plan returned from the closed statement.
thanks reviewing， rollbacked it.
| @@ -304,6 +306,14 @@ public void putMetrics(MetricsRecord record) { | |||
| } catch (SQLException e) { | |||
| LOGGER.error("Could not write metric: \n" + record + " to prepared statement:\n" + stmt, | |||
| e); | |||
| } finally { | |||
There was a problem hiding this comment.
Why not a simple try-with-resources ?
There was a problem hiding this comment.
Why not a simple try-with-resources ?
changed it.
| @@ -238,6 +239,14 @@ private void addToBatch(Span span) { | |||
| } catch (SQLException e) { | |||
| LOGGER.error("Could not write metric: \n" + span + " to prepared statement:\n" + stmt, | |||
| e); | |||
| } finally { | |||
There was a problem hiding this comment.
Why not simple try-with-resources?
chaijunjie0101
force-pushed
the
PHOENIX-7316
branch
2 times, most recently
from
4051656
to
a81867a
Compare
chaijunjie0101
force-pushed
the
PHOENIX-7316
branch
from
a81867a
to
ff868ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.