PHOENIX-4797 file not found or file exist exception when create glob… #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when namespace mapping is enabled
…rk in SkipScanFilter
…rk in SkipScanFilter (fix test failures)
…s not work in SkipScanFilter (fix test failures)" This reverts commit 45a9c27.
…s not work in SkipScanFilter" This reverts commit b0220fa.
… for parallelization
…es with only row key columns
…ocales (Shehzaad Nakhoda)
…SYSTEM tables to create tables
…e links for views and not for indexes
…mn value (Xavier Jodoin)
Client impersonation is no longer tied to SPNEGO auth. Signed-off-by: Josh Elser <elserj@apache.org>
…StatsWithMinStatsUpdateFreq of StatsCollectorIT
…tUpdatesStatsWithMinStatsUpdateFreq of StatsCollectorIT" This reverts commit 98f7a69.
… key found and added results for scan ordered queries(Rajeshbabu)
karanmehta93
reviewed
Jul 5, 2018
| import java.util.Collections; | ||
| import java.util.Iterator; | ||
| import java.util.List; | ||
| import java.util.*; |
There was a problem hiding this comment.
Nit: you should not have wildcard imports as this is probably unnecessary diff
|
hi, Thanks for reminding me, I remove the wildcard imports. |
karanmehta93
reviewed
Jul 5, 2018
| @@ -65,7 +66,8 @@ public TableSnapshotResultIterator(Configuration configuration, Scan scan, ScanM | |||
| this.scan = scan; | |||
| this.scanMetricsHolder = scanMetricsHolder; | |||
| this.scanIterator = UNINITIALIZED_SCANNER; | |||
| this.restoreDir = new Path(configuration.get(PhoenixConfigurationUtil.RESTORE_DIR_KEY)); | |||
| this.restoreDir = new Path(new Path(configuration.get(PhoenixConfigurationUtil.RESTORE_DIR_KEY)), | |||
There was a problem hiding this comment.
Path also offers other API at https://hadoop.apache.org/docs/r2.8.2/api/org/apache/hadoop/fs/Path.html
You can specify both of the params as String
…l index use -snaopshot option
|
Thank you for your advice，I've changed it to use both ”String“ Path api; |
karanmehta93
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when create global index use -snaopshot option in mapreduce task
multi mapper use the same restore dir to work with snapshot.
1,mapper will remove the file after mapper task as the other mapper will read the file
2,mapper will create the file when begin mapper task as the other mapper will create the file too
the 1 will cause the file not found and the 2 will case the file is exists
I change this to let mappers use different dirs to work with snapshot,after this patch,the -snapshot option can works well .