PHOENIX-4817 Fixed Phoenix Tracing Web Application #311

MrSandmanRUS · 2018-07-18T12:30:27Z

Fixed check null, trace table name, webapp path, column names. Fixed traceserver.py

…name, webapp path, column names). Fixed traceserver.py

MrSandmanRUS · 2018-07-18T12:31:43Z

Fixed Phoenix Tracing Web Application, fixed traceserver.py

joshelser · 2018-07-18T16:27:32Z

bin/traceserver.py

@@ -116,8 +116,10 @@

 #    " -Xdebug -Xrunjdwp:transport=dt_socket,address=5005,server=y,suspend=n " + \
 #    " -XX:+UnlockCommercialFeatures -XX:+FlightRecorder -XX:FlightRecorderOptions=defaultrecording=true,dumponexit=true" + \
-java_cmd = '%(java)s $PHOENIX_OPTS ' + \
-    '-cp ' + hbase_config_path + os.pathsep + phoenix_utils.phoenix_traceserver_jar + os.pathsep + phoenix_utils.phoenix_client_jar + \
+java_cmd = '%(java)s  ' + \


Seems like $PHOENIX_OPTS was dropped. Was this not being interpolated correctly? Is this environment variable propagated into the traceserver java process?

https://issues.apache.org/jira/browse/PHOENIX-2659
I think it's your comment:
"Josh Elser added a comment - 12/Feb/16 03:23
ok, PHOENIX_OPTS isn't working because subprocess isn't popping a shell like sqlline does. It will automatically get added to PQS's environment already. We can just remove that.
Steve is spot-on for the argument parsing. It's just busted."
So, I just remove it.

All in all, when I remove it, the server successfully starts and works correctly.

The issue is that subprocess doesn't handle shell variable expansion "in the command". Subprocess has API to provide an environment to the process being run.

$PHOENIX_OPTS and $PHOENIX_TRACESERVER_OPTS should be placed into the subprocess's environment, not just dropped.

Do I need to add something like this?

phoenix_opts= os.getenv('PHOENIX_OPTS', '')
......
if hbase_env.has_key('PHOENIX_OPTS'):
phoenix_opts= hbase_env['PHOENIX_OPTS']
.....
java_cmd = '%(java)s ' + phoenix_opts +
....

Actually, looks like queryserver.py doesn't include $PHOENIX_OPTS so let's just leave that to clients. $PHOENIX_TRACESERVER_OPTS is inlined, so you're good. Sorry for the confusion.

Ok, thank you

joshelser · 2018-07-18T16:30:07Z

phoenix-tracing-webapp/src/main/java/org/apache/phoenix/tracingwebapp/http/Main.java

-        ProtectionDomain domain = Main.class.getProtectionDomain();
-        URL location = domain.getCodeSource().getLocation();
-        String webappDirLocation = location.toString().split("target")[0] +"src/main/webapp";
+        String webappDirLocation = DEFAULT_WEBAPP_DIR_LOCATION;


Suggest dropping webappDirLocation and just using DEFAULT_WEBAPP_DIR_LOCATION since this is not configurable anyways.

joshelser · 2018-07-18T16:30:40Z

phoenix-tracing-webapp/src/main/java/org/apache/phoenix/tracingwebapp/http/TraceServlet.java

-
+  @Override
+  public void init() {
+    org.apache.hadoop.conf.Configuration conf = HBaseConfiguration.create();


Import org.apache.hadoop.conf.Configuration please.

joshelser · 2018-07-18T16:35:00Z

phoenix-tracing-webapp/src/main/java/org/apache/phoenix/tracingwebapp/http/TraceServlet.java

    }
-    if(!logic.equals(LOGIC_AND) || !logic.equals(LOGIC_OR)) {
-    	throw new RuntimeException("Wrong logical operator passed to the query. Only "+ LOGIC_AND+","+LOGIC_OR+" are allowed.") ;
+    if (logic != null && (!logic.equals(LOGIC_AND) && !logic.equals(LOGIC_OR))) {


Parenthesis around (!logic.equals(LOGIC_AND) && !logic.equals(LOGIC_OR)) are unnecessary, please drop them.

SiCheng-Zheng · 2018-07-20T10:35:30Z

traceserver.py start NO JSP Support for /, did not find org.apache.jasper.servlet.JspServlet

@MrSandmanRUS

MrSandmanRUS · 2018-07-20T10:47:23Z

It's ok, just info message, try to open localhost:8864
@mygood

SiCheng-Zheng · 2018-07-20T11:04:38Z

Tracing List is ok but Trace Count Chart Graph
Request URL: http://192.168.178.31:8864/trace/?action=getCount
Request Method: GET
Status Code: 500 Unknown tracename: description

see trace log

@MrSandmanRUS

MrSandmanRUS · 2018-07-20T11:13:49Z

Can you show me your trace table? Column “description” is standard column of this table, if you start tracing via hbase-site.xml
@mygood

SiCheng-Zheng · 2018-07-20T11:19:30Z

hbase-site.xml default SYSTEM.TRACING_STATS
CREATE TABLE SYSTEM.TRACING_STATS (
trace_id BIGINT NOT NULL,
parent_id BIGINT NOT NULL,
span_id BIGINT NOT NULL,
description VARCHAR,
start_time BIGINT,
end_time BIGINT,
hostname VARCHAR,
tags.count SMALLINT,
annotations.count SMALLINT,
CONSTRAINT pk PRIMARY KEY (trace_id, parent_id, span_id)
)
Phoenix Tracing List

Is it caused by this problem? NO JSP Support for /, did not find org.apache.jasper.servlet.JspServlet

@MrSandmanRUS

MrSandmanRUS · 2018-07-20T11:26:05Z

You use version from apache phoenix, I fixed this bug and some others, just compile my sources
@mygood

SiCheng-Zheng · 2018-07-20T11:29:09Z

apache-phoenix-4.11.0-HBase-1.1-bin 、hadoop-2.7.1
@MrSandmanRUS

MrSandmanRUS · 2018-07-20T11:31:20Z

It's ok, clone my branch and compile only web application, then rename jars for your version, then replace it with web application phoenix jars
@mygood

SiCheng-Zheng · 2018-07-20T12:02:48Z

Thank you very much for the problem.

@MrSandmanRUS

SiCheng-Zheng · 2018-07-25T09:38:50Z

You use version from apache phoenix 、hbase 、hadoop
@MrSandmanRUS

MrSandmanRUS · 2018-07-25T11:37:29Z

Yes
@mygood

SiCheng-Zheng · 2018-07-25T11:45:59Z

MrSandmanRUS · 2018-07-25T13:10:34Z

Add to hbase-site.xml:

phoenix.trace.enabled
true

@mygood

… trace table name, webapp path, column names) and traceserver.py Closes #311 Signed-off-by: Josh Elser <elserj@apache.org>

Fixed Phoenix Tracing Web Application (fixed check null, trace table …

070192c

…name, webapp path, column names). Fixed traceserver.py

MrSandmanRUS changed the title ~~Fixed Phoenix Tracing Web Application~~ PHOENIX-4817 Fixed Phoenix Tracing Web Application Jul 18, 2018

fixed null logiс comparison

01f60e8

joshelser requested changes Jul 18, 2018

View reviewed changes

Vitaly Monastyrev added 2 commits July 19, 2018 01:27

fixed formatting style

cf92678

fixed variable name

33eb1ec

asfgit pushed a commit that referenced this pull request Jul 25, 2018

PHOENIX-4817 Fixed Phoenix Tracing Web Application (fixed check null,…

faf4fb2

… trace table name, webapp path, column names) and traceserver.py Closes #311 Signed-off-by: Josh Elser <elserj@apache.org>

asfgit pushed a commit that referenced this pull request Jul 25, 2018

PHOENIX-4817 Fixed Phoenix Tracing Web Application (fixed check null,…

8a874cc

… trace table name, webapp path, column names) and traceserver.py Closes #311 Signed-off-by: Josh Elser <elserj@apache.org>

asfgit closed this in 6b363b3 Jul 25, 2018

asfgit pushed a commit that referenced this pull request Jul 25, 2018

PHOENIX-4817 Fixed Phoenix Tracing Web Application (fixed check null,…

1f7e320

… trace table name, webapp path, column names) and traceserver.py Closes #311 Signed-off-by: Josh Elser <elserj@apache.org>

asfgit pushed a commit that referenced this pull request Jul 29, 2018

PHOENIX-4817 Fixed Phoenix Tracing Web Application (fixed check null,…

09ceb39

… trace table name, webapp path, column names) and traceserver.py Closes #311 Signed-off-by: Josh Elser <elserj@apache.org>

asfgit pushed a commit that referenced this pull request Aug 3, 2018

PHOENIX-4817 Fixed Phoenix Tracing Web Application (fixed check null,…

82ec54f

… trace table name, webapp path, column names) and traceserver.py Closes #311 Signed-off-by: Josh Elser <elserj@apache.org>

asfgit pushed a commit that referenced this pull request Aug 3, 2018

PHOENIX-4817 Fixed Phoenix Tracing Web Application (fixed check null,…

f0f8b9f

… trace table name, webapp path, column names) and traceserver.py Closes #311 Signed-off-by: Josh Elser <elserj@apache.org>

asfgit pushed a commit that referenced this pull request Aug 3, 2018

PHOENIX-4817 Fixed Phoenix Tracing Web Application (fixed check null,…

c8d46e0

… trace table name, webapp path, column names) and traceserver.py Closes #311 Signed-off-by: Josh Elser <elserj@apache.org>

asfgit pushed a commit that referenced this pull request Aug 3, 2018

PHOENIX-4817 Fixed Phoenix Tracing Web Application (fixed check null,…

76f242a

… trace table name, webapp path, column names) and traceserver.py Closes #311 Signed-off-by: Josh Elser <elserj@apache.org>

asfgit pushed a commit that referenced this pull request Aug 3, 2018

PHOENIX-4817 Fixed Phoenix Tracing Web Application (fixed check null,…

1813ec8

… trace table name, webapp path, column names) and traceserver.py Closes #311 Signed-off-by: Josh Elser <elserj@apache.org>

asfgit pushed a commit that referenced this pull request Aug 3, 2018

PHOENIX-4817 Fixed Phoenix Tracing Web Application (fixed check null,…

4eac3ae

… trace table name, webapp path, column names) and traceserver.py Closes #311 Signed-off-by: Josh Elser <elserj@apache.org>

asfgit pushed a commit that referenced this pull request Oct 17, 2018

PHOENIX-4817 Fixed Phoenix Tracing Web Application (fixed check null,…

3493203

… trace table name, webapp path, column names) and traceserver.py Closes #311 Signed-off-by: Josh Elser <elserj@apache.org>

asfgit pushed a commit that referenced this pull request Oct 17, 2018

PHOENIX-4817 Fixed Phoenix Tracing Web Application (fixed check null,…

f876b9d

… trace table name, webapp path, column names) and traceserver.py Closes #311 Signed-off-by: Josh Elser <elserj@apache.org>

asfgit pushed a commit that referenced this pull request Oct 17, 2018

PHOENIX-4817 Fixed Phoenix Tracing Web Application (fixed check null,…

5db8699

… trace table name, webapp path, column names) and traceserver.py Closes #311 Signed-off-by: Josh Elser <elserj@apache.org>

asfgit pushed a commit that referenced this pull request Oct 17, 2018

PHOENIX-4817 Fixed Phoenix Tracing Web Application (fixed check null,…

5660452

… trace table name, webapp path, column names) and traceserver.py Closes #311 Signed-off-by: Josh Elser <elserj@apache.org>

asfgit pushed a commit that referenced this pull request Oct 17, 2018

PHOENIX-4817 Fixed Phoenix Tracing Web Application (fixed check null,…

20ce56f

… trace table name, webapp path, column names) and traceserver.py Closes #311 Signed-off-by: Josh Elser <elserj@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PHOENIX-4817 Fixed Phoenix Tracing Web Application #311

PHOENIX-4817 Fixed Phoenix Tracing Web Application #311

MrSandmanRUS commented Jul 18, 2018

MrSandmanRUS commented Jul 18, 2018

joshelser Jul 18, 2018

MrSandmanRUS Jul 18, 2018 •

edited

MrSandmanRUS Jul 18, 2018 •

edited

joshelser Jul 24, 2018

MrSandmanRUS Jul 24, 2018 •

edited

joshelser Jul 24, 2018

MrSandmanRUS Jul 24, 2018

joshelser Jul 18, 2018

MrSandmanRUS Jul 18, 2018

joshelser Jul 18, 2018

MrSandmanRUS Jul 18, 2018

joshelser Jul 18, 2018

MrSandmanRUS Jul 18, 2018

SiCheng-Zheng commented Jul 20, 2018 •

edited

MrSandmanRUS commented Jul 20, 2018

SiCheng-Zheng commented Jul 20, 2018 •

edited

MrSandmanRUS commented Jul 20, 2018 •

edited

SiCheng-Zheng commented Jul 20, 2018 •

edited

MrSandmanRUS commented Jul 20, 2018 •

edited

SiCheng-Zheng commented Jul 20, 2018

MrSandmanRUS commented Jul 20, 2018 •

edited

SiCheng-Zheng commented Jul 20, 2018

SiCheng-Zheng commented Jul 25, 2018

MrSandmanRUS commented Jul 25, 2018

SiCheng-Zheng commented Jul 25, 2018

MrSandmanRUS commented Jul 25, 2018 •

edited

PHOENIX-4817 Fixed Phoenix Tracing Web Application #311

PHOENIX-4817 Fixed Phoenix Tracing Web Application #311

Conversation

MrSandmanRUS commented Jul 18, 2018

MrSandmanRUS commented Jul 18, 2018

Choose a reason for hiding this comment

MrSandmanRUS Jul 18, 2018 • edited

Choose a reason for hiding this comment

MrSandmanRUS Jul 18, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MrSandmanRUS Jul 24, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SiCheng-Zheng commented Jul 20, 2018 • edited

MrSandmanRUS commented Jul 20, 2018

SiCheng-Zheng commented Jul 20, 2018 • edited

MrSandmanRUS commented Jul 20, 2018 • edited

SiCheng-Zheng commented Jul 20, 2018 • edited

MrSandmanRUS commented Jul 20, 2018 • edited

SiCheng-Zheng commented Jul 20, 2018

MrSandmanRUS commented Jul 20, 2018 • edited

SiCheng-Zheng commented Jul 20, 2018

SiCheng-Zheng commented Jul 25, 2018

MrSandmanRUS commented Jul 25, 2018

SiCheng-Zheng commented Jul 25, 2018

MrSandmanRUS commented Jul 25, 2018 • edited

MrSandmanRUS Jul 18, 2018 •

edited

MrSandmanRUS Jul 18, 2018 •

edited

MrSandmanRUS Jul 24, 2018 •

edited

SiCheng-Zheng commented Jul 20, 2018 •

edited

SiCheng-Zheng commented Jul 20, 2018 •

edited

MrSandmanRUS commented Jul 20, 2018 •

edited

SiCheng-Zheng commented Jul 20, 2018 •

edited

MrSandmanRUS commented Jul 20, 2018 •

edited

MrSandmanRUS commented Jul 20, 2018 •

edited

MrSandmanRUS commented Jul 25, 2018 •

edited