PHOENIX-3547 Supporting more number of indices per table. #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk in SkipScanFilter (fix test failures)
…s not work in SkipScanFilter (fix test failures)" This reverts commit 45a9c27.
…s not work in SkipScanFilter" This reverts commit b0220fa.
…mmutable indexes
… for parallelization
…ase data tables
…t table or view
…es with only row key columns
…ocales (Shehzaad Nakhoda)
…SYSTEM tables to create tables
…while upserting
…e links for views and not for indexes
…ies in CQSI Signed-off-by: aertoria <castives@gmail.com>
…ableRef, Map<ImmutableBytesPtr,RowMutationState>> mutations
…s (Pedro Boado)
…StatsWithMinStatsUpdateFreq of StatsCollectorIT
…tUpdatesStatsWithMinStatsUpdateFreq of StatsCollectorIT" This reverts commit 98f7a69.
… key found and added results for scan ordered queries(Rajeshbabu)
…e not to run query
Lease renewal is the only mechanism under which connections are removed from the connectionQueue. Calling close() on a connection doesn't proactively remove it from the instance of ConnectionQueryServicesImpl.
…or delete not to run query" This reverts commit 2883226.
This reverts commit d35a751.
…a and Rahul Gidwani)
Currently the number of indices per Phoenix table is bound to maximum of 65535 (java.lang.short) which might be a hard limit for applications requiring to have unlimited number of indices. This change will consider any new table created in Phoenix to support view index ids to be in the range of -9,223,372,036,854,775,808 to 9,223,372,036,854,775,807 (java.lang.Long) which is undoubtably big enough to cover this requirement. Any existing Phoenix table will still continue to support only maximum of 65535 of indices. A new boolean column (BOOLEAN USE_LONG_VIEW_INDEX DEFAULT FALSE) is added to SYSTEM.CATALOG to specify each Phoenix table's support for large number of indices. On new table creation the value for USE_LONG_VIEW_INDEX will be set to `true` while this value would be false for any existing table.
Currently the number of indices per Phoenix table is bound to maximum of 65535 (java.lang.Short) which is a limitation for applications requiring to have unlimited number of indices. This change will consider any new table created in Phoenix to support view index ids to be in the range of -9,223,372,036,854,775,808 to 9,223,372,036,854,775,807 (java.lang.Long) which is undoubtably big enough to cover this requirement. Any existing Phoenix table will still continue to support only maximum of 65535 of indices. A new boolean column (USE_LONG_VIEW_INDEX BOOLEAN DEFAULT FALSE) is added to SYSTEM.CATALOG to specify each Phoenix table's support for large number of indices. On each new Phoenix table creation the value for USE_LONG_VIEW_INDEX will be set to `true` while this value would be false for any existing table.
|
@m2je Thanks for the PR. Can you please update the PR so that it uses the correct branch, so that we can see only your changes? This PR currently has 250+ commits. |
|
@m2je Thanks for the contribution. Can you please update the PR to use the correct branch. It currently has 250+ commits, so it hard to review your changes. |
|
I don't know what happened. Let me open a new pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHOENIX-3547 Supporting more number of indices per table.
Currently the number of indices per Phoenix table is bound to maximum of 65535 (java.lang.Short) which is a limitation for applications requiring to have unlimited number of indices.
This change will consider any new table created in Phoenix to support view index ids to be in the range of -9,223,372,036,854,775,808 to 9,223,372,036,854,775,807 (java.lang.Long) which is undoubtably big enough to cover this requirement.
Any existing Phoenix table will still continue to support only maximum of 65535 of indices.
A new boolean column (USE_LONG_VIEW_INDEX BOOLEAN DEFAULT FALSE) is added to SYSTEM.CATALOG to specify each Phoenix table's support for large number of indices.
On each new Phoenix table creation the value for USE_LONG_VIEW_INDEX will be set to
truewhile this value would be false for any existing table.