PHOENIX-4835 LoggingPhoenixConnection should log metrics upon connect… #328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion close
@ankitsinghal I did some refactoring in tests and added new tests for the scenario along with now logging metrics both on close and commit. Hence, a quick look at PR would be helpful.
There is one more small pending problem, metrics won't be logged when auto_commit is set to true. Will file a separate Jira for that.
FYI, Closed original PR since it had incorrect title.