PHOENIX-4903 Use same hash cache RPC message across all calls #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 let me check the tests and merge it. Super straightforward. Thanks Marcell! |
|
Sorry, I forgot to include the text to automatically close this in the commit message. Can you click the "close pull request" button please, @ortutay? |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ticket https://issues.apache.org/jira/browse/PHOENIX-4903 , this change makes it so a single RPC message is used to distribute the hash cache across region servers. The previous code would have O(N) memory usage. This has O(1) memory usage.