PHOENIX-4765 Add client and server side config property to enable rol… #406
Conversation
…lback of splittable System Catalog if required
|
@karanmehta93 Can you please review? |
| // this flag denotes that we will continue to write parent table column metadata while creating | ||
| // a child view and also block metadata changes that were previously propagated to children | ||
| // before 4.15, so that we can rollback the upgrade to 4.15 if required | ||
| private boolean allowSystemCatalogRollback; |
There was a problem hiding this comment.
@twdsilva don't we need to have a way to figure out if a rollback is currently in progress as well? Once the rollback has already happened and the SYSTEM.CATALOG timestamp is < the min_splittable_SYSCAT timestamp, can we then acquire locks only when the SYSCAT timestamp is >= min_splittable_SYSCAT timestamp AND allowedSystemCatalogRollback is true, instead of always acquiring locks based on just the value of this new flag?
There was a problem hiding this comment.
Had a conversation offline with Thomas and the underlying point in my comment above is already being addressed. Thanks @twdsilva.
|
Once flipped back to "false", setting this flag back to "true" may not cleanly rollback since SYSCAT may have split since then. Let's add a comment about that as well as the SYSTEM.CHILD_LINK metadata that we discussed. Otherwise +1. Thanks @twdsilva |
…lback of splittable System Catalog if required
@ChinmaySKulkarni can you please review. This PR adds a config that is used to enable rollback of splittable SYSTEM.CATALOG if required. If the config is true, we continue storing the parent table column metadata while creating a view. We also block any add columns and while creating a view try to lock the parent table to prevent conflicting concurrent changes.