PHOENIX-2265 Disallow creation of view over HBase table if PK not spe… #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbwong
reviewed
Feb 12, 2019
phoenix-core/src/main/java/org/apache/phoenix/compile/CreateTableCompiler.java
Outdated
Show resolved
Hide resolved
dbwong
approved these changes
Feb 12, 2019
|
@twdsilva @karanmehta93 @ChinmaySKulkarni |
|
A couple of nits for the tests. Overall lgtm. Thanks @yanxinyi |
|
combined multi-commits into one. |
|
followed @gjacoby126 suggestion and moved the test to ViewIT file. |
yanxinyi
force-pushed
the
master
branch
2 times, most recently
from
f9a0c17
to
45c0a11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently allow a Phoenix view to be defined over an HBase table without specifying a primary key.
Fixed bug by adding pk check at CreateTableCompiler.compile. If no PK specified, it will throw a PK missing exception error.