PHOENIX-5181 support Math sin/cos/tan functions #458
Conversation
|
@yanxinyi overall looks good. I think the offline discussions we had regarding precision and rounding errors are the main points of concern. Can you add tests that reflect such cases? |
|
Offline synced with @ChinmaySKulkarni about the precision issue, and Phoenix PDecimal class already takes care of it. Other similar Math functions, such as power, implemented the same way as I do, but |
|
Can you add some IT's that test the grammar as well? @yanxinyi |
|
@karanmehta93 added IT tests |
|
Offline discussed with @karanmehta93, used |
|
@karanmehta93 , were there any other changes you wanted to the trig function feature? |
| ddl = | ||
| "CREATE TABLE " + tableName + " (k VARCHAR NOT NULL PRIMARY KEY, doub DOUBLE)"; | ||
| conn.createStatement().execute(ddl); | ||
| conn.commit(); |
There was a problem hiding this comment.
Commit is not needed after ddl statements.
|
|
||
| literal = LiteralExpression.newConstant(value, dataType, SortOrder.DESC); | ||
| boolean ret2 = testExpression(literal, expectedResult, testedFunction); | ||
| assertEquals(ret1, ret2); |
There was a problem hiding this comment.
Why is this required? If both ret1 and ret2 return false, this would still pass. Is that intended?
There was a problem hiding this comment.
As discussed offline, @yanxinyi will fix this in another Jira.
No description provided.