PHOENIX-5184: HBase and Phoenix connection leaks in Indexing code path, OrphanViewTool and PhoenixConfigurationUtil #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentpoon
reviewed
Mar 9, 2019
There was a problem hiding this comment.
Thanks for tracking these down @ChinmaySKulkarni .
Mostly lgtm, but I only looked at the index related classes (but not the e.g. the view/orphan ones)
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/PhoenixRecordWriter.java
Show resolved
Hide resolved
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexScrutinyMapper.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexScrutinyMapper.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java
Outdated
Show resolved
Hide resolved
|
Thanks for the review @vincentpoon. I have incorporated your review comments. @twdsilva @gjacoby126 @kadirozde please provide feedback as well. Thanks. |
|
Thanks for the reviews @vincentpoon @kadirozde @twdsilva! |
…h, OrphanViewTool and PhoenixConfigurationUtil
ChinmaySKulkarni
force-pushed
the
PHOENIX-5184
branch
from
d98731f
to
6c72f3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.