Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-5264 Implement the toString method of EncodedQualifiersColumnProjectionFilter #497

Merged
merged 1 commit into from
May 6, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,15 @@ public boolean isFamilyEssential(byte[] name) {

@Override
public String toString() {
return "";
StringBuilder sb = new StringBuilder(100);
sb.append(String.format("EmptyCFName: %s, ", Bytes.toStringBinary(this.emptyCFName)));
sb.append(String.format("EncodingScheme: %s, ", this.encodingScheme));
sb.append(String.format("TrackedColumns: %s, ", this.trackedColumns));
sb.append("ConditionOnlyCfs: ");
for (byte[] conditionOnlyCf : this.conditionOnlyCfs) {
sb.append(String.format("%s, ", Bytes.toStringBinary(conditionOnlyCf)));
}
return sb.toString();
}

@Override
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.phoenix.filter;

import java.util.BitSet;
import java.util.HashSet;
import org.apache.phoenix.schema.PTable.QualifierEncodingScheme;
import junit.framework.TestCase;

public class EncodedQualifiersColumnProjectionFilterTest extends TestCase {

private final String someEmptyCFName = "cfName1";
private final String someConditionalCFName1 = "conditionalCfName1";
private final String someConditionalCFName2 = "conditionalCfName2";
private final QualifierEncodingScheme someQualifiedEncodingScheme = QualifierEncodingScheme.ONE_BYTE_QUALIFIERS;
private final BitSet someBitSet;
private EncodedQualifiersColumnProjectionFilter filter;

public EncodedQualifiersColumnProjectionFilterTest() {
HashSet<byte[]> conditionalCFNames = new HashSet<byte[]>(2);
conditionalCFNames.add(someConditionalCFName1.getBytes());
conditionalCFNames.add(someConditionalCFName2.getBytes());

this.someBitSet = new BitSet();
this.someBitSet.xor(new BitSet(0)); // All 1s

this.filter = new EncodedQualifiersColumnProjectionFilter(
this.someEmptyCFName.getBytes(),
someBitSet,
conditionalCFNames,
this.someQualifiedEncodingScheme);
}

public void testToString() {
String outputString = this.filter.toString();

assertTrue(outputString.contains("EmptyCFName"));
assertTrue(outputString.contains("EncodingScheme"));
assertTrue(outputString.contains("TrackedColumns"));
assertTrue(outputString.contains("ConditionOnlyCfs"));
assertTrue(outputString.contains(this.someEmptyCFName));
assertTrue(outputString.contains(this.someConditionalCFName1));
assertTrue(outputString.contains(this.someConditionalCFName2));
assertTrue(outputString.contains(this.someBitSet.toString()));
}
}