PHOENIX-4871: ParameterMetadata for join query plans is empty #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@twdsilva @ChinmaySKulkarni - Mind taking a look? Patch looks good to me but you guys know the read path better than I do. |
ChinmaySKulkarni
approved these changes
Jun 26, 2019
|
The tests already added are a minimized version of the misbehaving query in the JIRA, just with the names changed to align with the existing schema in the test suites. I can add a comment to those two test cases pointing them back to the JIRA. I can also add an integration test to the phoenix-query-server repo for end-to-end, but that would have to be a different PR in the other repository. |
|
@BoxMiles , could you please rebase against master? Looks like there's a merge conflict that prevents this patch from being committed. |
change constructor parameter order add upserts to QueryServerBasicsIT pass down BindManager to child QueryCompilers created for explicit subqueries
|
@gjacoby126 Do you need additional action on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.