PHOENIX-5104: breaks client backwards compatibility #544
Conversation
There was a problem hiding this comment.
If we have a client older than 4.15 it will not be able to decode the viewIndexId if the "phoenix.index.longViewIndex.enabled" is set to true. Until all the clients have been upgraded to 4.15 we will have to set "phoenix.index.longViewIndex.enabled" to false.
| * @return | ||
| */ | ||
| private PDataType getViewIndexDataType() throws SQLException { | ||
| boolean supportsLongViewIndexId = "true".equalsIgnoreCase(connection.getClientInfo(LONG_VIEW_INDEX_ENABLED_ATTRIB)); |
There was a problem hiding this comment.
Can you please add a default value for LONG_VIEW_INDEX_ENABLED_ATTRIB to QueryServicesOptions and set it to false and look it up similar to :
boolean asyncIndexBuildEnabled = connection.getQueryServices().getProps().getBoolean(
QueryServices.INDEX_ASYNC_BUILD_ENABLED,
QueryServicesOptions.DEFAULT_INDEX_ASYNC_BUILD_ENABLED);
|
bq. This feature is by default avaiable to phoenix version 5 and above. |
Fixing by adding a new connection property "phoenix.index.longViewIndex.enabled" which is by default false. Clients can set this property to true to be able to use longViewIndexes.
m2je
force-pushed
the
PHOENIX-5104-4.x-HBase-1.4
branch
from
89404a4
to
3334bc7
Compare
@chrajeshbabu Updated the comment. Also will open a same PR for the master branch. |
|
Closing in favor of #548 |
Fixing by adding a new connection property "phoenix.index.longViewIndex.enabled" which is by default false.
Clients can set this property to true to be able to use longViewIndexes on phoenix 4.x version. This feature is by default avaiable to phoenix version 5 and above.