PHOENIX-5419: Converting anonymous to inner class in TracingQueryPlan #559
Conversation
There was a problem hiding this comment.
+1, thanks @ankitjain64. I'll commit once we get a clean test run on the JIRA.
| @@ -295,4 +236,71 @@ public Long getEstimateInfoTimestamp() throws SQLException { | |||
| public List<OrderBy> getOutputOrderBys() { | |||
| return Collections.<OrderBy> emptyList(); | |||
| } | |||
|
|
|||
| private class QueryResultIterator implements ResultIterator { | |||
There was a problem hiding this comment.
nit: could you please rename the private class to TraceQueryResultIterator?
There was a problem hiding this comment.
@swaroopak : Can you please have a look now. Thanks.
ankitjain64
force-pushed
the
PHOENIX-5419
branch
from
222dd7a
to
576165b
Compare
|
@ankitjain64 could you please include the JIRA id PHOENIX-5419 in the commit header. |
Converting anonymous to inner class in TracingQueryPlan PHOENIX-5419: Converting anonymous to inner class in TracingQueryPlan Converting anonymous to inner class Rename Inner class as per comments Converting anonymous to inner class in TracingQueryPlan Converting anonymous to inner class Rename Inner class as per comments Converting anonymous to inner class in TracingQueryPlan Converting anonymous to inner class Rename Inner class as per comments
ankitjain64
force-pushed
the
PHOENIX-5419
branch
from
be2fcaa
to
ed8f674
Compare
@gjacoby126 : Done. Thanks |
|
@ankitjain64 - for future reference, when you squash your commits into a single one, please also edit the commit message so that it only has the one line. This commit message had a line for each of the former commits, and since the UI truncated it to just show the first, I didn't notice until after I pushed the merge button. I can fix it when I push to the 4.15 branches, but since this repo doesn't allow force pushes, I think it will have to remain messy in master. |
Sure, I will make sure about it from next time. Thank you. |
No description provided.