PHOENIX-5428 Upgrade maven-checkstyle-plugin version #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upgrades maven-checkstyle-plugin to 3.1.0 and updates the checker.xml config files to work with recent checkstyle versions
|
Looks like we're skipping checkstyle for the build now, but I can see that this does run validations. Tough to say if the change is "OK" since there are so many violations. |
asfgit
pushed a commit
that referenced
this pull request
Sep 4, 2019
This upgrades maven-checkstyle-plugin to 3.1.0 and updates the checker.xml config files to work with recent checkstyle versions Closes #565 Signed-off-by: Josh Elser <elserj@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Sep 4, 2019
This upgrades maven-checkstyle-plugin to 3.1.0 and updates the checker.xml config files to work with recent checkstyle versions Closes #565 Signed-off-by: Josh Elser <elserj@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Sep 4, 2019
This upgrades maven-checkstyle-plugin to 3.1.0 and updates the checker.xml config files to work with recent checkstyle versions Closes #565 Signed-off-by: Josh Elser <elserj@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades maven-checkstyle-plugin to 3.1.0 and
updates the checker.xml config files to work with recent
checkstyle versions