Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHOENIX-5451 #568

Closed
wants to merge 1 commit into from
Closed

PHOENIX-5451 #568

wants to merge 1 commit into from

Conversation

comnetwork
Copy link
Contributor

@comnetwork comnetwork commented Aug 21, 2019 •
edited

This PR is mainly for:

  1. For Join, added a new JoinTable.pruneSubselectAliasedNodes at the end of JoinCompiler.compile to pruning columns for each JoinCompiler.Table according to
    JoinCompiler.columnNodes.
  2. For subquery, added a new SubselectRewriter.pruneInnerSubselectAliasedNodes at the end of
    SubselectRewriter.flatten to pruning columns for the DerivedTableNode.getSelect according to ParseNodeUtil.collectReferencedColumnNamesForSingleTable.
  3. Added a FromCompiler.refreshDerivedTableNode to refresh the inner state of MultiTableColumnResolver for the DerivedTableNode when the DerivedTableNode is changed after column pruning.

@twdsilva
Copy link
Contributor

@ChinmaySKulkarni do you have some spare cycles to review this?

@twdsilva
Copy link
Contributor

twdsilva commented Sep 3, 2019

+1 LGTM

@comnetwork comnetwork closed this Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@comnetwork @twdsilva