Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-5474 IndexTool should report the number of rows built #587

Closed
wants to merge 1 commit into from
Closed

PHOENIX-5474 IndexTool should report the number of rows built #587

wants to merge 1 commit into from

Conversation

kadirozde
Copy link
Contributor

No description provided.

Copy link
Contributor

@gjacoby126 gjacoby126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic itself looks good -- could we have a test that verifies that the counters are incremented properly? (Might have to be two unit tests of the new Writable and the mapper since instrumenting MapReduce internals can be tough.)

@kadirozde
Copy link
Contributor Author

Logic itself looks good -- could we have a test that verifies that the counters are incremented properly? (Might have to be two unit tests of the new Writable and the mapper since instrumenting MapReduce internals can be tough.)

@gjacoby126, I get the row count from the MR job and verify it in the new version of the PR. Would you please review it? Thanks

Copy link
Contributor

@gjacoby126 gjacoby126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks @kadirozde (And very nice solution to getting the test counter.)

@kadirozde
Copy link
Contributor Author

+1, thanks @kadirozde (And very nice solution to getting the test counter.)

Thank you for pointing out that we need to verify the counter reported by mappers.

@gjacoby126
Copy link
Contributor

JIRA is resolved, closing PR.

@gjacoby126 gjacoby126 closed this Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants