Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHOENIX-5747 Add upsert tests for immutable table indexes #720

Closed
wants to merge 2 commits into from
Closed

PHOENIX-5747 Add upsert tests for immutable table indexes #720

wants to merge 2 commits into from

Conversation

tkhurana
Copy link
Contributor

@tkhurana tkhurana commented Mar 3, 2020

No description provided.

@tkhurana
Copy link
Contributor Author

tkhurana commented Mar 3, 2020

@kadirozde @gokceni

gokceni
gokceni suggested changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@gokceni gokceni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some main comments:

  1. These tests look similar with the difference of Coprocessor class. Can you refactor them and just call a function with Coprocessor class?
  2. Remove System.out calls

swaroopak
swaroopak requested changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@swaroopak swaroopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits and could you please add tests for view indexes?

phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ImmutableIndexExtendedIT.java Outdated Show resolved Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ImmutableIndexExtendedIT.java Outdated Show resolved Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ImmutableIndexExtendedIT.java Outdated Show resolved Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ImmutableIndexExtendedIT.java Outdated Show resolved Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ImmutableIndexExtendedIT.java Show resolved Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ImmutableIndexExtendedIT.java Outdated Show resolved Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ImmutableIndexExtendedIT.java Outdated Show resolved Hide resolved
@tkhurana
- Refactored tests to remove duplicate test logic
23009d9 
- Removed system.out calls
- Added tests for view index
@tkhurana tkhurana requested a review from swaroopak March 10, 2020 00:54
@tkhurana
Copy link
Contributor Author

@gokceni addressed your feedback

swaroopak
swaroopak approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@swaroopak swaroopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Could you please confirm if this test also needs to cover the "apparently immutable table" scenario?

@swaroopak swaroopak closed this Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swaroopak swaroopak swaroopak approved these changes

@gokceni gokceni gokceni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@tkhurana @swaroopak @gokceni