Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHOENIX-4521: Allow Pherf scenario to define per query max allowed query execution duration after which thread is interrupted #749

Closed
wants to merge 1 commit into from
Closed

PHOENIX-4521: Allow Pherf scenario to define per query max allowed query execution duration after which thread is interrupted #749

wants to merge 1 commit into from

Conversation

christinefeng
Copy link
Contributor

No description provided.

@christinefeng
Copy link
Contributor Author

@ChinmaySKulkarni @abhishek-chouhan

@christinefeng christinefeng changed the title PHOENIX-4521: Allow Pherf scenario to define per query max allowed query execution duration after which thread is interrupted [WIP!!] PHOENIX-4521: Allow Pherf scenario to define per query max allowed query execution duration after which thread is interrupted Mar 30, 2020
@christinefeng christinefeng changed the title [WIP!!] PHOENIX-4521: Allow Pherf scenario to define per query max allowed query execution duration after which thread is interrupted PHOENIX-4521: Allow Pherf scenario to define per query max allowed query execution duration after which thread is interrupted Apr 2, 2020
ChinmaySKulkarni
ChinmaySKulkarni requested changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@ChinmaySKulkarni ChinmaySKulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christinefeng please take a look at the comments. Thanks

phoenix-pherf/pom.xml Outdated Show resolved Hide resolved
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/QueryResult.java Show resolved Hide resolved
phoenix-pherf/src/it/java/org/apache/phoenix/pherf/PherfMainIT.java Outdated Show resolved Hide resolved
phoenix-pherf/src/it/java/org/apache/phoenix/pherf/PherfMainIT.java Outdated Show resolved Hide resolved
phoenix-pherf/src/it/java/org/apache/phoenix/pherf/PherfMainIT.java Outdated Show resolved Hide resolved
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultiThreadedRunnerTest.java Outdated Show resolved Hide resolved
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultiThreadedRunnerTest.java Outdated Show resolved Hide resolved
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultiThreadedRunnerTest.java Outdated Show resolved Hide resolved
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultiThreadedRunnerTest.java Outdated Show resolved Hide resolved
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultiThreadedRunner.java Outdated Show resolved Hide resolved
@christinefeng christinefeng force-pushed the PHOENIX-4521 branch 2 times, most recently from ddfa1b8 to 260a846 Compare April 13, 2020 23:14
ChinmaySKulkarni
ChinmaySKulkarni requested changes Apr 17, 2020
View reviewed changes
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/ThreadTime.java Show resolved Hide resolved
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultiThreadedRunner.java Outdated
for (long i = numberOfExecutions; (i > 0 && ((EnvironmentEdgeManager.currentTimeMillis() - start)
< executionDurationInMs)); i--) {
for (long i = 0; i < numberOfExecutions; i++) {
long elapsedTime = EnvironmentEdgeManager.currentTimeMillis() - start;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we be more explicit with the variable names here, for clarity? For ex: querySetStartTime, querySetElapsedTime..etc. and similarly for variables used to time the query

phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/RunTime.java Show resolved Hide resolved
phoenix-pherf/src/test/java/org/apache/phoenix/pherf/workload/MultiThreadedRunnerTest.java Outdated Show resolved Hide resolved
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultiThreadedRunner.java Outdated Show resolved Hide resolved
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultiThreadedRunner.java Outdated Show resolved Hide resolved
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/MultiThreadedRunner.java Outdated Show resolved Hide resolved
@christinefeng
PHOENIX-4521: Allow Pherf scenario to define per query max allowed qu…
a1e0272 
…ery execution duration after which thread is interrupted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChinmaySKulkarni ChinmaySKulkarni ChinmaySKulkarni requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@christinefeng @ChinmaySKulkarni