Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-5817 Prepatch script is a psycho killer #754

Closed
wants to merge 1 commit into from

Conversation

stoty
Copy link
Contributor

@stoty stoty commented Apr 3, 2020

No description provided.

@dbwong
Copy link
Contributor

dbwong commented Apr 3, 2020

I was looking at what HBase was doing and they don't appear to use similar killer type code. They also have onboarded on to yetus/docker for test framework/requirements so likely they don't need to.
Long term we should likely prioritize https://issues.apache.org/jira/browse/PHOENIX-5032.

In the short term, i'm not sure we have similar output to https://github.com/apache/hbase/blob/master/dev-support/flaky-tests/findHangingTests.py so we may rely on committers to tear down stuff if we misbehave. @ChinmaySKulkarni FYI
Code changes look good though.

Copy link
Contributor

@ChinmaySKulkarni ChinmaySKulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Thanks for fixing this @stoty

@ChinmaySKulkarni
Copy link
Contributor

This is also what was found on https://issues.apache.org/jira/browse/PHOENIX-5754

@stoty
Copy link
Contributor Author

stoty commented Apr 6, 2020

merged

@stoty stoty closed this Apr 6, 2020
@stoty stoty deleted the PHOENIX-5817 branch September 16, 2020 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants