PHOENIX-5808 Improve shaded artifact naming convetions #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provide unversioned symlinks in the assembly for -server and -client drop the deprecated phoenix-<version>-client/server symlinks/jars update the python lib to look for the unversioned client jar
joshelser
requested changes
Apr 23, 2020
phoenix-assembly/pom.xml
Outdated
| </goals> | ||
| <configuration> | ||
| <executable>ln</executable> | ||
| <workingDirectory></workingDirectory> |
There was a problem hiding this comment.
Should be ${project.basedir}/../phoenix-client/target? I think this leaves it in phoenix-assembly and is then not reflected in the binary tarball.
$ ll phoenix-5.1.0-SNAPSHOT-hbase-2.2
...
-rw-r--r-- 1 jelser staff 133M Apr 23 11:47 phoenix-client-5.1.0-SNAPSHOT-hbase-2.2.jar
-rw-r--r-- 1 jelser staff 18K Apr 23 11:46 phoenix-client-5.1.0-SNAPSHOT.jar
lrwxr-xr-x 1 jelser staff 43B Apr 23 11:47 phoenix-client.jar -> phoenix-client-5.1.0-SNAPSHOT-hbase-2.2.jar
There was a problem hiding this comment.
Thanks for the catch @joshelser
Fixed.
Also added explicit dependency on phoenix-client and phoenix-server so that partial builds work.
add explicit dependencies to phoenix-assembly
joshelser
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provide unversioned symlinks in the assembly for -server and -client
drop the deprecated phoenix--client/server symlinks/jars
update the python lib to look for the unversioned client jar