PHOENIX-5580 Wrong values seen when updating a view for a table that … #768
Conversation
| @@ -2896,6 +2916,49 @@ public int getIndexDataColumnCount() { | |||
| return indexDataColumnCount_; | |||
| } | |||
|
|
|||
| // optional string parentTableType = 24; | |||
| public static final int PARENTTABLETYPE_FIELD_NUMBER = 24; | |||
There was a problem hiding this comment.
nit: PARENT_TABLE_TYPE_FIELD_NUMBER
| * <code>optional string parentTableType = 24;</code> | ||
| */ | ||
| public com.google.protobuf.ByteString | ||
| getParentTableTypeBytes() { |
There was a problem hiding this comment.
this can fit in one line, any reason to break to multiple? applies to other places as well
| /** | ||
| * <code>optional string parentTableType = 24;</code> | ||
| */ | ||
| public Builder setParentTableType( |
There was a problem hiding this comment.
Indent looks little off in this function
| @@ -1887,6 +1899,11 @@ public boolean isImmutableRows() { | |||
| return immutableRows; | |||
| } | |||
|
|
|||
| public boolean isTableIndex() { | |||
| if (parentTableType == null) return false; | |||
| @@ -1887,6 +1899,11 @@ public boolean isImmutableRows() { | |||
| return immutableRows; | |||
| } | |||
|
|
|||
| public boolean isTableIndex() { | |||
There was a problem hiding this comment.
I haven't come across anything as a table index and might confuse while reading as global index comes with its own table. How about isViewIndex() and use this with a negation at line#1667?
There was a problem hiding this comment.
Makes sense, made the change and pushed in latest commit
| @@ -1887,6 +1899,13 @@ public boolean isImmutableRows() { | |||
| return immutableRows; | |||
| } | |||
|
|
|||
| public boolean isViewIndex() { | |||
| if (parentTableType == null) { | |||
There was a problem hiding this comment.
@sguggilam - In the upgrade scenario where the clients don't have the new proto and hence parentTableType isn't defined, will this still work OK to have isViewIndex incorrectly return true?
There was a problem hiding this comment.
Yes @gjacoby126 , the logic that is added in the change makes sure that the behavior is unchanged for the clients that doesn't pass the parentTableType field (the logic uses a OR condition with !isViewIndex() )
|
Already merged. |
…has an index