Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-5872 Close Internal Phoenix Connections that were running dur… #775

Closed
wants to merge 2 commits into from

Conversation

dbwong
Copy link
Contributor

@dbwong dbwong commented May 4, 2020

…ing cancel

…ing cancel

Signed-off-by: Xinyi Yan <yanxinyi@apache.org>
@stoty
Copy link
Contributor

stoty commented Sep 28, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ patch 0m 3s #775 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
GITHUB PR #775
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/1/console
versions git=2.17.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@gjacoby126
Copy link
Contributor

@dbwong - looks like this was committed to 4.x but not master, but now needs a rebase to be committed. When you get a minute, could you please take a look?

@dbwong
Copy link
Contributor Author

dbwong commented Nov 24, 2020

Updated @ChinmaySKulkarni @gjacoby126 for master changes please review i'll update the patch on the jira as well. @sakshamgangwar fyi for master path for your follow up jira as well.

@stoty
Copy link
Contributor

stoty commented Nov 24, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 5m 16s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 12m 33s master passed
+1 💚 compile 0m 58s master passed
+1 💚 checkstyle 2m 21s master passed
+1 💚 javadoc 0m 47s master passed
+0 🆗 spotbugs 2m 52s phoenix-core in master has 966 extant spotbugs warnings.
-0 ⚠️ patch 2m 59s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
-1 ❌ mvninstall 1m 1s root in the patch failed.
-1 ❌ compile 0m 50s phoenix-core in the patch failed.
-1 ❌ javac 0m 50s phoenix-core in the patch failed.
-1 ❌ checkstyle 2m 26s phoenix-core: The patch generated 64 new + 4559 unchanged - 15 fixed = 4623 total (was 4574)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 0m 41s the patch passed
-1 ❌ spotbugs 0m 49s phoenix-core in the patch failed.
_ Other Tests _
-1 ❌ unit 0m 46s phoenix-core in the patch failed.
+1 💚 asflicense 0m 10s The patch does not generate ASF License warnings.
32m 19s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #775
Optional Tests dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname Linux ebb1d6da4dc2 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / f1f92aa
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt
javac https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt
checkstyle https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/patch-spotbugs-phoenix-core.txt
unit https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/testReport/
Max. process+thread count 94 (vs. ulimit of 30000)
modules C: phoenix-core U: phoenix-core
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-775/2/console
versions git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@gjacoby126 gjacoby126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gjacoby126
Copy link
Contributor

@dbwong , apologies, but could you please rebase one more time?

@ChinmaySKulkarni
Copy link
Contributor

Ping @dbwong can you please rebase so we can get this in master as well? There is another Jira (PHOENIX-6256) which depends on this along with @sakshamgangwar's Jira. FYI @yanxinyi

jpisaac pushed a commit to jpisaac/phoenix that referenced this pull request Jun 10, 2022
@stoty
Copy link
Contributor

stoty commented Aug 1, 2023

Already merged.

@stoty stoty closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants