-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHOENIX-6078 Remove Internal Phoenix Connections from parent LinkedQueue when closed #858
Conversation
…eue when closed
Please open up follow up jira for unhappy path handling. Thanks. |
@dbwong added that here: https://issues.apache.org/jira/browse/PHOENIX-6079 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@ChinmaySKulkarni and @sakshamgangwar , what's the status of this PR? I see that it's approved (and skimming through seems pretty straightforward). Any reason it hasn't been committed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Kicked off a Yetus build to make sure this still passes tests. If it's green I'll merge this tomorrow. |
@gjacoby126 Thanks for triggering the tests again. |
💔 -1 overall
This message was automatically generated. |
Test passed save for one JVM crash. Merging. |
https://issues.apache.org/jira/browse/PHOENIX-6078