PHOENIX-5032 add Apache Yetus to Phoenix #882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also replace findbugs support with spotbugs support in maven build and get mvn site working, and add all reports to it
stoty
force-pushed
the
PHOENIX-5032-4.x
branch
from
b1a1bed
to
55668ee
Compare
| # Update SpotBugs | ||
| ##### | ||
| RUN rm -rf /opt/spotbugs \ | ||
| && git clone https://github.com/stoty/spotbugs.git \ |
There was a problem hiding this comment.
isnt it should be https://github.com/spotbugs/spotbugs.git?
There was a problem hiding this comment.
For the record, as we have discussed offline, this branch has a fix for a bug in spotbugs 4.12 that breaks the spotbugs result analysis features used by Yetus.
| RUN rm -rf /opt/spotbugs \ | ||
| && git clone https://github.com/stoty/spotbugs.git \ | ||
| && cd spotbugs \ | ||
| && git checkout PHOENIX-1161-backport \ |
There was a problem hiding this comment.
is this branch also correct?
There was a problem hiding this comment.
The branch name is somewhat misleading, as it's actually a fix for Spotbugs issue 1161
chrajeshbabu
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also replace findbugs support with spotbugs support in maven build
and get mvn site working, and add all reports to it