PHOENIX-6055: Not matching index mutation error needs to report more … #891
Conversation
| @@ -768,7 +768,8 @@ public boolean verifySingleIndexRow(Result indexRow, IndexToolVerificationResult | |||
| } | |||
| } else { | |||
| byte[] dataKey = indexMaintainer.buildDataRowKey(new ImmutableBytesWritable(indexRow.getRow()), viewConstants); | |||
| String errorMsg = "Not matching index row"; | |||
| String errorMsg = String.format("Not matching index row. matchingCount=0. expectedIndex=%d. expectedMutationSize=%d. actualIndex=%d. actualMutationSize=%d. expectedTs=%d. actualTs=%d", | |||
There was a problem hiding this comment.
The version of this file is not the most recent as I noticed that it does not have the MaxLookBack changes. The patch with the latest version should be different, I think. Also, there is no need to include expected and actual timestamps in the error message since they are reported as separate columns in the output table. We should fix those reported values instead. Please use the most recent version of IndexRebuildRegionScanner.java and resubmit your patch.
There was a problem hiding this comment.
@kadirozde Rebased. I don't think we put the actualTs since in the next line we always put 0L. For the expected, since we put expectedMutations.get(0) I don't think it hurts to put what it is here in case we change the above loop and since we put the actualTs. what do you think?
There was a problem hiding this comment.
@gokceni, this fix is not correct and will not be very useful for troubleshooting. First, the check actual == null is not meaningful here. You need to check if actualIndex < actualSIze then actual is useful and we should report the type of actual (put or delete) and the timestamp of the actual. I still think we absolutely should not include the timestamps in the error message as we have separate columns for them. In the following line expectedMutationList.get(0)) should be replaced by getTimestamp(expected)). expected cannot be null here. If actualIndex < actualSIze then getTimestamp(actual)) should be reported instead of 0L.
gokceni
force-pushed
the
PHOENIX-6055
branch
from
4c7beb2
to
a621324
Compare
…information rather than first expected mutation
gokceni
force-pushed
the
PHOENIX-6055
branch
from
a621324
to
62fb22a
Compare
|
💔 -1 overall
This message was automatically generated. |
|
JIRA is resolved, closing PR |
…information rather than first expected mutation