-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHOENIX-6146 Run precommit checks on github PRs #895
Conversation
9e08b71
to
2745c44
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is see that Yetus didn't run any of the java based tests. I'm assuming that's because Yetus was smart enough to know that it didn't need to. Have you tested to make sure that when there is a change, we get unit tests run?
I think even if you haven't, I'm happy to just see this wired up. Iteration on testing is better than the current state.
Thank you @joshelser . I haven't actually tested the Java part on that on GitHub integration, but the Jenkins patch job uses the same personality, and almost the same Yetus options, so I'd be very surprised if it didn't work. It's probably going to need an addendum or three as we start using it anger anyway, just as you've said. |
No description provided.