Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-6058 When maxLookback is not enabled, IndexTool should not do… #901

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Conversation

kadirozde
Copy link
Contributor

… deep verification

@gjacoby126
Copy link
Contributor

I can see two ways to handle the case where max lookback is disabled / not supported :

  1. As @kadirozde has done here, treat everything as beyond max lookback. This will let the jobs pass, but all missing / invalid rows will go into the beyond max lookback counters rather than the normal ones.
  2. Treat nothing as beyond max lookback, because the concept is disabled / not supported, but change the reducer to pass the job in this case. This will put all missing / invalid rows in the normal counters.

Either of these could cause user confusion. In the first case, users might wonder why everything's in the max lookback counters, and not know to look at the data more closely in case there's a real failure. In the second case, users might wonder why the job passed even though there's failed counters, and not know that some of them might be compaction artifacts from the lack of max lookback. (This might be alleviated with logging, assuming users read the logs.)

Curious on what others' thoughts are, or if there's another approach I'm missing.

Copy link
Contributor

@gjacoby126 gjacoby126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kadirozde kadirozde merged commit 432474e into apache:4.x Dec 9, 2020
asfgit pushed a commit that referenced this pull request Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants