PHOENIX-6172 Updating VIEW_INDEX_ID column type and ts in Syscat with… #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
virajjasani
reviewed
Oct 14, 2020
phoenix-core/src/it/java/org/apache/phoenix/end2end/UpgradeIT.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/it/java/org/apache/phoenix/end2end/UpgradeIT.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java
Outdated
Show resolved
Hide resolved
phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
| metaConnection, rowKey, tableName.getBytes()); | ||
| LOGGER.info("Updated VIEW_INDEX_ID data type from SMALLINT TO BIGINT."); | ||
| } catch (Exception e) { | ||
| LOGGER.error("Updating VIEW_INDEX_ID data type failed."); |
There was a problem hiding this comment.
Change to : LOGGER.error(" ... ", e) so we see the actual error too
There was a problem hiding this comment.
Or maybe that's not required since you're already catching the exception and logging it inside the updateViewIndexIdColumnDataTypeFromShortToLong() method. Can this method still throw then?
| LOGGER.info("Updated VIEW_INDEX_ID data type from SMALLINT TO BIGINT."); | ||
| } catch (Exception e) { | ||
| LOGGER.error("Updating VIEW_INDEX_ID data type failed."); | ||
|
|
There was a problem hiding this comment.
nit: Remove extra new line
ChinmaySKulkarni
approved these changes
Oct 17, 2020
yanxinyi
force-pushed
the
PHOENIX-6172-4.X
branch
from
62acff3
to
8671a95
Compare
|
💔 -1 overall
This message was automatically generated. |
… a 4.16 upgrade script
yanxinyi
force-pushed
the
PHOENIX-6172-4.X
branch
from
8671a95
to
236b258
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… a 4.16 upgrade script