Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHOENIX-6194 : Include slf4j-api dependency in phoenix-tools #926

Closed
wants to merge 1 commit into from
Closed

PHOENIX-6194 : Include slf4j-api dependency in phoenix-tools #926

wants to merge 1 commit into from

Conversation

virajjasani
Copy link
Contributor

No description provided.

@virajjasani
Copy link
Contributor Author

@stoty could you please take a look?

@stoty
Copy link
Contributor

stoty commented Oct 17, 2020

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
-1 ❌ mvninstall 37m 30s root in master failed.
+1 💚 compile 0m 30s master passed
+1 💚 javadoc 0m 16s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 40m 28s the patch passed
+1 💚 compile 0m 33s the patch passed
+1 💚 javac 0m 33s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 15s the patch passed
_ Other Tests _
+1 💚 unit 3m 0s phoenix-tools in the patch passed.
+1 💚 asflicense 0m 9s The patch does not generate ASF License warnings.
83m 50s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-926/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #926
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux f3ad6d8bb78f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev/phoenix-personality.sh
git revision master / 1784848
Default Java Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
mvninstall https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-926/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt
Test Results https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-926/1/testReport/
Max. process+thread count 579 (vs. ulimit of 30000)
modules C: phoenix-tools U: phoenix-tools
Console output https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-926/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani
Copy link
Contributor Author

mvninstall for patch is +1

Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@stoty stoty closed this Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants