PHOENIX-6126 : All createViewAddChildLink requests should go to corresponding region of SYSTEM.CHILD_LINK #948

virajjasani · 2020-10-29T18:53:47Z

No description provided.

stoty · 2020-10-29T22:28:21Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	5m 21s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	13m 26s	master passed
+1 💚	compile	0m 58s	master passed
+1 💚	checkstyle	1m 40s	master passed
+1 💚	javadoc	0m 44s	master passed
+0 🆗	spotbugs	2m 53s	phoenix-core in master has 969 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	7m 33s	the patch passed
+1 💚	compile	0m 54s	the patch passed
+1 💚	javac	0m 54s	the patch passed
-1 ❌	checkstyle	1m 42s	phoenix-core: The patch generated 9 new + 2897 unchanged - 13 fixed = 2906 total (was 2910)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 43s	the patch passed
-1 ❌	spotbugs	3m 9s	phoenix-core generated 2 new + 967 unchanged - 2 fixed = 969 total (was 969)
		_ Other Tests _
-1 ❌	unit	171m 55s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 27s	The patch does not generate ASF License warnings.
		214m 5s

Reason	Tests
FindBugs	module:phoenix-core
	org.apache.phoenix.query.ConnectionQueryServicesImpl$12.call() may fail to clean up java.sql.Statement Obligation to clean up resource created at ConnectionQueryServicesImpl.java:up java.sql.Statement Obligation to clean up resource created at ConnectionQueryServicesImpl.java:[line 3205] is not discharged
	org.apache.phoenix.query.ConnectionQueryServicesImpl$12.call() may fail to close Statement At ConnectionQueryServicesImpl.java:Statement At ConnectionQueryServicesImpl.java:[line 3205]

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#948
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux 4f9b12eb25e1 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / `ff46e35`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/1/testReport/
Max. process+thread count	6456 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/1/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2020-10-30T09:45:26Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	12m 49s	master passed
+1 💚	compile	0m 59s	master passed
+1 💚	checkstyle	1m 39s	master passed
+1 💚	javadoc	0m 44s	master passed
+0 🆗	spotbugs	2m 54s	phoenix-core in master has 969 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	7m 29s	the patch passed
+1 💚	compile	0m 51s	the patch passed
+1 💚	javac	0m 51s	the patch passed
-1 ❌	checkstyle	1m 41s	phoenix-core: The patch generated 9 new + 2897 unchanged - 13 fixed = 2906 total (was 2910)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 44s	the patch passed
-1 ❌	spotbugs	3m 4s	phoenix-core generated 2 new + 967 unchanged - 2 fixed = 969 total (was 969)
		_ Other Tests _
-1 ❌	unit	167m 2s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 26s	The patch does not generate ASF License warnings.
		204m 0s

Reason	Tests
FindBugs	module:phoenix-core
	org.apache.phoenix.query.ConnectionQueryServicesImpl$12.call() may fail to clean up java.sql.Statement Obligation to clean up resource created at ConnectionQueryServicesImpl.java:up java.sql.Statement Obligation to clean up resource created at ConnectionQueryServicesImpl.java:[line 3205] is not discharged
	org.apache.phoenix.query.ConnectionQueryServicesImpl$12.call() may fail to close Statement At ConnectionQueryServicesImpl.java:Statement At ConnectionQueryServicesImpl.java:[line 3205]

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#948
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux f96f257cd74a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / `ff46e35`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
spotbugs	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/2/testReport/
Max. process+thread count	6788 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/2/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

stoty · 2020-10-30T13:56:36Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 3s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	12m 22s	master passed
+1 💚	compile	0m 56s	master passed
+1 💚	checkstyle	1m 40s	master passed
+1 💚	javadoc	0m 43s	master passed
+0 🆗	spotbugs	2m 47s	phoenix-core in master has 969 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	7m 36s	the patch passed
+1 💚	compile	0m 53s	the patch passed
+1 💚	javac	0m 53s	the patch passed
-1 ❌	checkstyle	1m 42s	phoenix-core: The patch generated 43 new + 2862 unchanged - 48 fixed = 2905 total (was 2910)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 43s	the patch passed
+1 💚	spotbugs	3m 5s	phoenix-core generated 0 new + 967 unchanged - 2 fixed = 967 total (was 969)
		_ Other Tests _
-1 ❌	unit	174m 50s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 26s	The patch does not generate ASF License warnings.
		211m 18s

Reason	Tests
Failed junit tests	phoenix.end2end.TableSnapshotReadsMapReduceIT

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#948
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux ee69bb2ca91d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / `ff46e35`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/3/testReport/
Max. process+thread count	6736 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/3/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ChinmaySKulkarni

Small nit otherwise +1. Thanks @virajjasani

ChinmaySKulkarni · 2020-10-30T21:29:11Z

phoenix-core/src/main/java/org/apache/phoenix/query/ChildLinkMetaDataServiceCallBack.java

+        ServerRpcController controller = new ServerRpcController();
+        CoprocessorRpcUtils.BlockingRpcCallback<MetaDataProtos.MetaDataResponse> rpcCallback =
+            new CoprocessorRpcUtils.BlockingRpcCallback<>();
+        ChildLinkMetaDataProtos.CreateViewAddChildLinkRequest.Builder builder =


Can we import static some of these constants so it looks cleaner?

…sponding region of SYSTEM.CHILD_LINK

stoty · 2020-10-31T14:06:13Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 1s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	12m 51s	master passed
+1 💚	compile	0m 55s	master passed
+1 💚	checkstyle	1m 39s	master passed
+1 💚	javadoc	0m 45s	master passed
+0 🆗	spotbugs	2m 51s	phoenix-core in master has 969 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	7m 24s	the patch passed
+1 💚	compile	0m 52s	the patch passed
+1 💚	javac	0m 52s	the patch passed
-1 ❌	checkstyle	1m 41s	phoenix-core: The patch generated 42 new + 2862 unchanged - 48 fixed = 2904 total (was 2910)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 44s	the patch passed
+1 💚	spotbugs	3m 9s	phoenix-core generated 0 new + 967 unchanged - 2 fixed = 967 total (was 969)
		_ Other Tests _
-1 ❌	unit	162m 16s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 26s	The patch does not generate ASF License warnings.
		199m 13s

Reason	Tests
Failed junit tests	phoenix.end2end.OrphanViewToolIT
	phoenix.end2end.TableSnapshotReadsMapReduceIT

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#948
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux c4973534832e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / `e828ef7`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/4/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/4/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/4/testReport/
Max. process+thread count	6781 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/4/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani · 2020-11-04T12:42:31Z

Now that this is merged, let me close the PR.
Thanks @ChinmaySKulkarni @yanxinyi for reviews!

ChinmaySKulkarni approved these changes Oct 30, 2020

View reviewed changes

PHOENIX-6126 : All createViewAddChildLink requests should go to corre…

b42f7b1

…sponding region of SYSTEM.CHILD_LINK

virajjasani closed this Nov 4, 2020

virajjasani deleted the PHOENIX-6126-master branch November 4, 2020 12:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PHOENIX-6126 : All createViewAddChildLink requests should go to corresponding region of SYSTEM.CHILD_LINK #948

PHOENIX-6126 : All createViewAddChildLink requests should go to corresponding region of SYSTEM.CHILD_LINK #948

virajjasani commented Oct 29, 2020

stoty commented Oct 29, 2020

stoty commented Oct 30, 2020

stoty commented Oct 30, 2020

ChinmaySKulkarni left a comment

ChinmaySKulkarni Oct 30, 2020

stoty commented Oct 31, 2020

virajjasani commented Nov 4, 2020

PHOENIX-6126 : All createViewAddChildLink requests should go to corresponding region of SYSTEM.CHILD_LINK #948

PHOENIX-6126 : All createViewAddChildLink requests should go to corresponding region of SYSTEM.CHILD_LINK #948

Conversation

virajjasani commented Oct 29, 2020

stoty commented Oct 29, 2020

stoty commented Oct 30, 2020

stoty commented Oct 30, 2020

ChinmaySKulkarni left a comment

Choose a reason for hiding this comment

ChinmaySKulkarni Oct 30, 2020

Choose a reason for hiding this comment

stoty commented Oct 31, 2020

virajjasani commented Nov 4, 2020