PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam… #953

richardantal · 2020-11-02T15:40:29Z

…p gives version as 4.15.x

stoty · 2020-11-02T19:33:13Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 3s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ 4.x Compile Tests _
+1 💚	mvninstall	11m 59s	4.x passed
+1 💚	compile	1m 0s	4.x passed
+1 💚	checkstyle	0m 36s	4.x passed
+1 💚	javadoc	0m 47s	4.x passed
+0 🆗	spotbugs	3m 8s	phoenix-core in 4.x has 953 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	6m 11s	the patch passed
+1 💚	compile	1m 0s	the patch passed
+1 💚	javac	1m 0s	the patch passed
+1 💚	checkstyle	0m 37s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 47s	the patch passed
+1 💚	spotbugs	3m 18s	the patch passed
		_ Other Tests _
-1 ❌	unit	198m 32s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 35s	The patch does not generate ASF License warnings.
		232m 12s

Reason	Tests
Failed junit tests	phoenix.end2end.FlappingLocalIndexIT
	phoenix.end2end.IndexExtendedIT
	phoenix.end2end.salted.SaltedTableIT
	phoenix.end2end.DerivedTableIT

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-953/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#953
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux 16f7a7438785 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `a8a9699`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-953/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-953/1/testReport/
Max. process+thread count	3468 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-953/1/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

gjacoby126 · 2020-11-02T22:12:17Z

Change itself looks good, @richardantal , but could we please have a simple test?

richardantal · 2020-11-03T08:53:47Z

Thanks @gjacoby126 for the review.
I wrote a test but we will have to update this version after releases.
I also checked the failing tests and the were successful locally.

virajjasani

Left one minor comment, looks good otherwise

virajjasani · 2020-11-03T10:58:24Z

phoenix-core/src/test/java/org/apache/phoenix/schema/MetaDataClientTest.java

+        long serversTimstamp = System.currentTimeMillis();
+        String version = MetaDataProtocol.getVersion(serversTimstamp);
+        assertEquals("4.16.x", version);  // We have to update it after every release
+        assertEquals(String.format("%d.%d.%s", PHOENIX_MAJOR_VERSION, PHOENIX_MINOR_VERSION, "x"),


I believe this assert might be better fit for all branches and the one above assertEquals("4.16.x", version); might not be needed. Thought?

Yeah, that is right!

…p gives version as 4.15.x

stoty · 2020-11-03T20:30:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ 4.x Compile Tests _
+1 💚	mvninstall	11m 3s	4.x passed
+1 💚	compile	0m 53s	4.x passed
+1 💚	checkstyle	0m 39s	4.x passed
+1 💚	javadoc	0m 45s	4.x passed
+0 🆗	spotbugs	2m 55s	phoenix-core in 4.x has 953 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 17s	the patch passed
+1 💚	compile	0m 55s	the patch passed
+1 💚	javac	0m 55s	the patch passed
+1 💚	checkstyle	0m 38s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 44s	the patch passed
+1 💚	spotbugs	3m 3s	the patch passed
		_ Other Tests _
-1 ❌	unit	127m 22s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 37s	The patch does not generate ASF License warnings.
		158m 1s

Reason	Tests
Failed junit tests	phoenix.end2end.ViewIT
	phoenix.end2end.index.GlobalMutableNonTxIndexIT

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-953/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#953
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux 26c002ff65c2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	4.x / `8aa243d`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-953/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-953/3/testReport/
Max. process+thread count	6949 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-953/3/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

richardantal force-pushed the PHOENIX-6091 branch from db061ae to d5c40ac Compare November 3, 2020 08:51

virajjasani reviewed Nov 3, 2020

View reviewed changes

PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam…

2f68a3d

…p gives version as 4.15.x

richardantal force-pushed the PHOENIX-6091 branch from d5c40ac to 2f68a3d Compare November 3, 2020 11:58

virajjasani approved these changes Nov 3, 2020

View reviewed changes

stoty closed this Nov 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam… #953

PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam… #953

richardantal commented Nov 2, 2020

stoty commented Nov 2, 2020

gjacoby126 commented Nov 2, 2020

richardantal commented Nov 3, 2020

virajjasani left a comment

virajjasani Nov 3, 2020

richardantal Nov 3, 2020

stoty commented Nov 3, 2020

PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam… #953

PHOENIX-6091 Calling MetaDataProtocol.getVersion() on a 4.16 timestam… #953

Conversation

richardantal commented Nov 2, 2020

stoty commented Nov 2, 2020

gjacoby126 commented Nov 2, 2020

richardantal commented Nov 3, 2020

virajjasani left a comment

Choose a reason for hiding this comment

virajjasani Nov 3, 2020

Choose a reason for hiding this comment

richardantal Nov 3, 2020

Choose a reason for hiding this comment

stoty commented Nov 3, 2020