PHOENIX-6184 : Emit indexAgeOfUnVerifiedRow metric during read repairs #956

virajjasani · 2020-11-05T12:09:04Z

No description provided.

virajjasani · 2020-11-05T12:29:39Z

@priyankporwal @gjacoby126 could you please take a look?
Thanks

stoty · 2020-11-05T15:19:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	14m 16s	master passed
+1 💚	compile	1m 0s	master passed
+1 💚	checkstyle	0m 36s	master passed
+1 💚	javadoc	0m 47s	master passed
+0 🆗	spotbugs	3m 7s	phoenix-core in master has 962 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	9m 0s	the patch passed
+1 💚	compile	0m 56s	the patch passed
+1 💚	javac	0m 56s	the patch passed
-1 ❌	checkstyle	0m 35s	phoenix-core: The patch generated 10 new + 272 unchanged - 6 fixed = 282 total (was 278)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 46s	the patch passed
+1 💚	spotbugs	3m 19s	the patch passed
		_ Other Tests _
-1 ❌	unit	152m 3s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 24s	The patch does not generate ASF License warnings.
		190m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-956/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#956
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux a110bf42a639 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / `6889645`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-956/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-956/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-956/1/testReport/
Max. process+thread count	6196 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-956/1/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

priyankporwal

Other than the rename of the metric, LGTM. Thanks @virajjasani for contributing this metric!

priyankporwal · 2020-11-05T17:40:47Z

phoenix-core/src/main/java/org/apache/phoenix/hbase/index/metrics/GlobalIndexCheckerSource.java

@@ -44,6 +44,10 @@
    String INDEX_REPAIR_FAILURE_TIME = "indexRepairFailureTime";
    String INDEX_REPAIR_FAILURE_TIME_DESC = "Histogram for the time in milliseconds for index row repair failures";

+    String INDEX_AGE_OF_UNVERIFIED_ROW = "indexAgeOfUnVerifiedRow";


Nit: "indexAgeOfUnVerifiedRow" => "unverifiedIndexRowAge"

stoty · 2020-11-05T21:18:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 4s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1 💚	mvninstall	14m 3s	master passed
+1 💚	compile	1m 1s	master passed
+1 💚	checkstyle	0m 34s	master passed
+1 💚	javadoc	0m 50s	master passed
+0 🆗	spotbugs	3m 14s	phoenix-core in master has 962 extant spotbugs warnings.
		_ Patch Compile Tests _
+1 💚	mvninstall	9m 2s	the patch passed
+1 💚	compile	0m 58s	the patch passed
+1 💚	javac	0m 58s	the patch passed
-1 ❌	checkstyle	0m 35s	phoenix-core: The patch generated 10 new + 272 unchanged - 6 fixed = 282 total (was 278)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	javadoc	0m 44s	the patch passed
+1 💚	spotbugs	3m 24s	the patch passed
		_ Other Tests _
-1 ❌	unit	160m 0s	phoenix-core in the patch failed.
+1 💚	asflicense	0m 31s	The patch does not generate ASF License warnings.
		198m 59s

Reason	Tests
Failed junit tests	phoenix.end2end.ViewMetadataIT

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-956/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#956
Optional Tests	dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile
uname	Linux d93f52079578 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev/phoenix-personality.sh
git revision	master / `6889645`
Default Java	Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
checkstyle	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-956/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
unit	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-956/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
Test Results	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-956/2/testReport/
Max. process+thread count	6213 (vs. ulimit of 30000)
modules	C: phoenix-core U: phoenix-core
Console output	https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-956/2/console
versions	git=2.7.4 maven=3.3.9 spotbugs=4.1.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

swaroopak

Thanks, @virajjasani

virajjasani · 2020-11-06T06:10:51Z

Thanks for the reviews @priyankporwal @swaroopak @yanxinyi !

virajjasani changed the title ~~PHOENIX-6184 : Emit ageOfUnverifiedRow metric during read repairs~~ PHOENIX-6184 : Emit indexAgeOfUnVerifiedRow metric during read repairs Nov 5, 2020

priyankporwal approved these changes Nov 5, 2020

View reviewed changes

PHOENIX-6184 : Emit ageOfUnverifiedRow metric during read repairs

5d9c05b

swaroopak approved these changes Nov 6, 2020

View reviewed changes

virajjasani closed this Nov 6, 2020

virajjasani deleted the PHOENIX-6184-master branch November 6, 2020 06:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PHOENIX-6184 : Emit indexAgeOfUnVerifiedRow metric during read repairs #956

PHOENIX-6184 : Emit indexAgeOfUnVerifiedRow metric during read repairs #956

virajjasani commented Nov 5, 2020

virajjasani commented Nov 5, 2020

stoty commented Nov 5, 2020

priyankporwal left a comment

priyankporwal Nov 5, 2020

stoty commented Nov 5, 2020

swaroopak left a comment

virajjasani commented Nov 6, 2020

PHOENIX-6184 : Emit indexAgeOfUnVerifiedRow metric during read repairs #956

PHOENIX-6184 : Emit indexAgeOfUnVerifiedRow metric during read repairs #956

Conversation

virajjasani commented Nov 5, 2020

virajjasani commented Nov 5, 2020

stoty commented Nov 5, 2020

priyankporwal left a comment

Choose a reason for hiding this comment

priyankporwal Nov 5, 2020

Choose a reason for hiding this comment

stoty commented Nov 5, 2020

swaroopak left a comment

Choose a reason for hiding this comment

virajjasani commented Nov 6, 2020